-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve from outDir #48190
resolve from outDir #48190
Conversation
Proof of concept for resolving microsoft#37378 Under the new proposed `compilerOptions.resolveFromOutDir` boolean, module resolution is attempted relative to the output folder. This is analogous to loading from the rootDirs, however it allows compilation where the output directory is configured on the command line rather than in the tsconfig.json. See the attached issue for context. TODO: - figure out what tests to add - reason about whether this interacts correctly with other related module resolution conditional logic - verify this works in some Bazel projects where the problem is observed
e7e5c17
to
0afea27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the suggestion was to compute outDir for the referenced project and not change module resolution.
Thanks @sheetalkamat I replied on the associated issue about why this design was chosen. |
Reading through the issue history, it looks like bazel doesn't need this PR anymore. I'm going to close it since I don't think @sheetalkamat 's concerns ever changed. @alexeagle let me know if we should re-open this. |
Under the new proposed
compilerOptions.resolveFromOutDir
boolean,module resolution is attempted relative to the output folder.
This is analogous to loading from the rootDirs, however it allows
compilation where the output directory is configured on the command line
rather than in the tsconfig.json.
See the attached issue for context.
TODO:
module resolution conditional logic
Fixes #22208
Fixes #37378