Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(48034): Get a literal string of type intersection in a template literal type #48044

Merged
merged 4 commits into from
Mar 22, 2022
Merged

fix(48034): Get a literal string of type intersection in a template literal type #48044

merged 4 commits into from
Mar 22, 2022

Conversation

islandryu
Copy link
Contributor

Fixes #48034

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Feb 26, 2022
@islandryu islandryu marked this pull request as ready for review February 26, 2022 09:34
@sandersn sandersn requested review from jakebailey and weswigham March 7, 2022 23:15
jakebailey
jakebailey reviewed Mar 7, 2022
View reviewed changes
src/compiler/checker.ts Outdated Show resolved Hide resolved
jakebailey
jakebailey reviewed Mar 18, 2022
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor; seems better.

src/compiler/checker.ts Outdated Show resolved Hide resolved
src/compiler/checker.ts Show resolved Hide resolved
@islandryu islandryu requested a review from jakebailey March 21, 2022 11:40
@jakebailey jakebailey merged commit bf0eef4 into microsoft:main Mar 22, 2022
@epmatsw epmatsw mentioned this pull request Jan 20, 2023
Closed
@jakebailey jakebailey mentioned this pull request Feb 18, 2023
Merged
@jakebailey jakebailey mentioned this pull request Oct 20, 2023
Open
@ahejlsberg ahejlsberg mentioned this pull request Nov 15, 2023
Closed
@DanielRosenwasser DanielRosenwasser mentioned this pull request Nov 16, 2023
Closed
@jakebailey jakebailey mentioned this pull request Nov 20, 2023
Closed
@jcalz jcalz mentioned this pull request Apr 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

@weswigham weswigham Awaiting requested review from weswigham

Assignees

@jakebailey jakebailey

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Template string type infers error when string intersect with object type
3 participants
@islandryu @jakebailey @typescript-bot