Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(47158): Removes comments when line variable declaration #47407

Merged
merged 9 commits into from
Feb 23, 2022
Merged

fix(47158): Removes comments when line variable declaration #47407

merged 9 commits into from
Feb 23, 2022

Conversation

islandryu
Copy link
Contributor

Fixes #47158

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 12, 2022
@islandryu islandryu marked this pull request as ready for review January 12, 2022 18:02
jakebailey
jakebailey reviewed Feb 16, 2022
View reviewed changes
src/compiler/emitter.ts Outdated Show resolved Hide resolved
jakebailey
jakebailey requested changes Feb 16, 2022
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments.

jakebailey
jakebailey reviewed Feb 17, 2022
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must have typo'd my suggestion, sorry! There's another one I noticed later.

src/compiler/emitter.ts Outdated Show resolved Hide resolved
src/compiler/transformers/ts.ts Outdated Show resolved Hide resolved
@islandryu
Copy link
Contributor Author

Thanks for the review!
I've committed suggestion.

jakebailey
jakebailey reviewed Feb 18, 2022
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last whitespace fix; not sure what GitHub suggestions was doing but it kept adding extra spaces.

Past that LGTM though maybe Wes wants to look to double check.

src/compiler/emitter.ts Outdated Show resolved Hide resolved
src/compiler/transformers/ts.ts Outdated Show resolved Hide resolved
@islandryu
Copy link
Contributor Author

I'm sorry.
I checked and committed this time.

jakebailey
jakebailey reviewed Feb 22, 2022
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the formatting change, but there's a baseline update that should be made before approval and merge as those public APIs got dropped so their definitions have to be reverted.

src/compiler/emitter.ts Outdated Show resolved Hide resolved
@islandryu
Copy link
Contributor Author

Thank you again and again.
I fixed the baseline.

@jakebailey jakebailey merged commit ff3b458 into microsoft:main Feb 23, 2022
@jakebailey jakebailey mentioned this pull request Feb 23, 2022
Merged
@jakebailey jakebailey mentioned this pull request Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

@weswigham weswigham Awaiting requested review from weswigham

Assignees

@jakebailey jakebailey

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript removes comments even when removeComments: false
3 participants
@islandryu @jakebailey @typescript-bot