-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin chalk to ^4.1 #46985
Pin chalk to ^4.1 #46985
Conversation
The PR is so huge I think because the lock was generated with npm7+; I think the old lock was npm 6 (so lock version 1); maybe redo this with npm 6 to prevent churn? |
Regenerated the lock file using npm@6 |
Related: #46931 Might want to revert those changes when you're pinning chalk anyway. |
Hm, perhaps we could change the offending build script (or, it was missed). Not sure where the user test PR thingy lives. |
(Pinning back and removing the odd |
I pinged @orta on that PR, but I'll mention him here too. Do we want to depend on |
Pinning to 4.2 is fine IMO 👍🏻 - both solve the underlaying issue. Makes sense that this would break on older nodes which don't support node's import infra. If this is forcing an update to the build infra then we can ship it independently later once that's sorted. |
I've reverted the changes in #46931 as well. |
@typescript-bot cherry-pick this to release-4.5 |
Heya @andrewbranch, I've started to run the task to cherry-pick this into |
I think this doesn't work after the branch has been deleted but we'll see |
Hey @andrewbranch, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.5 manually. |
* Pin chalk to ^4.1 * Revert microsoft#46931
* Pin chalk to ^4.1 * Revert #46931 Co-authored-by: Ron Buckton <[email protected]>
* Pin chalk to ^4.1 * Revert microsoft#46931
This limits the version of chalk we use to
^4.1.2
sincechalk@5
is now ESM only.