Check for type parameters on original type when getting type argument completions #46614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe argument constraint.
andrewbranch
approved these changes
Nov 1, 2021
tests/cases/fourslash/stringLiteralTypeCompletionsInTypeArgForNonGeneric1.ts
Outdated
Show resolved
Hide resolved
typescript-bot
added
For Milestone Bug
|
@typescript-bot cherry-pick this to release-4.5 |
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
|
Hey @DanielRosenwasser, I've opened #46675 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Nov 3, 2021
DanielRosenwasser
added a commit
that referenced
this pull request
Nov 3, 2021
Component commits: e77514a Add failing test. 3c0d51b Check for type parameters on the original type when asking for the type argument constraint. e7c8095 Update tests/cases/fourslash/stringLiteralTypeCompletionsInTypeArgForNonGeneric1.ts Co-authored-by: Daniel Rosenwasser <[email protected]>
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
… completions (microsoft#46614) * Add failing test. * Check for type parameters on the original type when asking for the type argument constraint. * Update tests/cases/fourslash/stringLiteralTypeCompletionsInTypeArgForNonGeneric1.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32874