Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module conversion #46567

Closed
wants to merge 7 commits into from
Closed

Module conversion #46567

wants to merge 7 commits into from

Conversation

elibarzilay
Copy link
Contributor

@elibarzilay elibarzilay commented Oct 28, 2021

This will be rebased often, and the commit pointers below will be updated. Generated by this script.

The work is tracked at #46744.

Best viewed by looking at each commit separately:

  • 2c98a7b UNINDENT BEFORE CONVERTING TO MODULES
    prepares for the conversion, it's doing only the unindentation as well as normalizes all files to end with a newline.
  • 548a326 CONVERTED TO MODULES
    Main conversion step
  • 809349d Make processDiagnosticMessages.ts generate a module
    Convert the diagnostic-generation script to create a module
  • 9a78868 Post conversion fixes
    b9a4a3a Some require -> import conversions
    Manual changes and tweaks to make things work
  • 32c2e60 TEMP STUFF - TODO MARKERS ETC
    Rest of the ongoing work, saved in a commit (will eventually become a proper part). This includes:
    • Disabling the two build steps that should be re-done via budling (buildServices, buildLssl).
    • Some improvements for imports, more would likely be added.
    • !!! comments marking places that might need adjusting.
  • 9910ffb Add a bundling step for tests
    This would change (done for all packages, and probably better), but added now to make running the tests easier for others

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 28, 2021
@typescript-bot
Copy link
Collaborator

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

@DanielRosenwasser
Copy link
Member

@ahejlsberg was wondering why in some places things like Symbol will get prefixed with ts., but not always.

(Also improve the generated comment at the top.)
This will change (should be done for all packages, and probably better),
but added now to make running the tests easier for others.
@jakebailey
Copy link
Member

Closing this; I'm now staging this work as a PR stack here: jakebailey#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants