-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module conversion #46567
Module conversion #46567
Conversation
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary |
3b3f8cd
to
8be16d9
Compare
8be16d9
to
32c2e60
Compare
9910ffb
to
d6c537e
Compare
@ahejlsberg was wondering why in some places things like |
(Also improve the generated comment at the top.)
This will change (should be done for all packages, and probably better), but added now to make running the tests easier for others.
696c616
to
23ce87d
Compare
Closing this; I'm now staging this work as a PR stack here: jakebailey#1 |
This will be rebased often, and the commit pointers below will be updated. Generated by this script.
The work is tracked at #46744.
Best viewed by looking at each commit separately:
prepares for the conversion, it's doing only the unindentation as well as normalizes all files to end with a newline.
Main conversion step
processDiagnosticMessages.ts
generate a moduleConvert the diagnostic-generation script to create a module
b9a4a3a Some
require
->import
conversionsManual changes and tweaks to make things work
Rest of the ongoing work, saved in a commit (will eventually become a proper part). This includes:
buildServices
,buildLssl
).!!!
comments marking places that might need adjusting.This would change (done for all packages, and probably better), but added now to make running the tests easier for others