-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit package.json realpath lookup to only successful resolutions #46209
Limit package.json realpath lookup to only successful resolutions #46209
Conversation
@typescript-bot pack this |
Heya @weswigham, I've started to run the tarball bundle task on this PR at 2286798. You can monitor the build here. |
Hey @weswigham, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build and an npm module you can use via |
@amcasey 's testing shows this to be a pretty significant perf improvement (over the other PR, too), so I'm going to merge this~ |
@weswigham Testing this change, it's about ~55% faster (~35% less build time) than 4.3.5, which is itself is >2x faster than 4.4.3. Is there a way to integrate this into a 4.4.4 release? |
@DanielRosenwasser would be the one to ask~ |
Will discuss with @DanielRosenwasser shortly. @typescript-bot cherry-pick this to release-4.4 |
Heya @andrewbranch, I've started to run the task to cherry-pick this into |
Hey @andrewbranch, I've opened #46230 for you. |
Component commits: 2286798 Limit package.json realpath lookup to only successful resolutions
Component commits: 2286798 Limit package.json realpath lookup to only successful resolutions Co-authored-by: Wesley Wigham <[email protected]>
To test if this is a possible fix for #46204