Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decorator metadata references to type-only-imported namespaces #44915

Merged
merged 3 commits into from
Aug 2, 2021

Conversation

andrewbranch
Copy link
Member

Fixes #42624

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jul 6, 2021
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. 1 minor style suggestion.

src/compiler/checker.ts Show resolved Hide resolved
@andrewbranch andrewbranch merged commit bfd5b2f into microsoft:main Aug 2, 2021
@andrewbranch andrewbranch deleted the bug/42624 branch August 2, 2021 21:18
@stevekanter
Copy link

@andrewbranch thanks so much for this! This has been an issue for me in a pretty large-scale application and has prevented me using import type to prevent errors. Any clue what version of TS this is going to be released in?

@andrewbranch
Copy link
Member Author

andrewbranch commented Aug 2, 2021

4.4.1 (RC), along with nightlies starting tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

emitDecoratorMetadata causes runtime errors by referencing type-only imports with namespaces
4 participants