Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array.prototype.sort - remove the need for compareFn to handle undefined values #44216

Closed
wants to merge 1 commit into from

Conversation

Brookke
Copy link

@Brookke Brookke commented May 22, 2021

Array.prototype.sort - remove the need for compareFn to handle undefined values

Fixes #41708

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 22, 2021
@ghost
Copy link

ghost commented May 22, 2021

CLA assistant check
All CLA requirements met.

@Brookke Brookke marked this pull request as ready for review May 22, 2021 14:13
@typescript-bot
Copy link
Collaborator

The TypeScript team hasn't accepted the linked issue #41708. If you can get it accepted, this PR will have a better chance of being reviewed.

@Brookke Brookke changed the title 41708 array sort Array.prototype.sort - remove the need for compareFn to handle undefined values May 22, 2021
@tjjfvi
Copy link
Contributor

tjjfvi commented May 22, 2021

IMO a: Exclude<T, undefined> is a bit cleaner

@Brookke
Copy link
Author

Brookke commented May 24, 2021

Happy to switch to a: Exclude<T, undefined> if that’s clearer. However I will await review and confirmation before switching :)

@sandersn sandersn self-assigned this Feb 18, 2022
@sandersn
Copy link
Member

The original issue #41708 needs to be added to #36554 before it will be accepted. In the meantime, I'd vote to close the PR because code tends to go stale pretty fast.

@Brookke
Copy link
Author

Brookke commented Feb 19, 2022

Requested @sandersn. Is there anything else I need to do? Would love to see this issue closed :)

@sandersn
Copy link
Member

We just need to make time to work through all issues with a significant update to Array. So far it hasn't made it to the front of our queue, though.

@weswigham weswigham removed their request for review March 5, 2022 01:43
@sandersn
Copy link
Member

To help with PR housekeeping, I'm going to close this PR until we finally update Array types.

@sandersn sandersn closed this Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Suggestion: Array.prototype.sort - remove the need for compareFn to handle undefined values
4 participants