Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(43879): for ( async of should be a syntax error #43886

Merged
merged 1 commit into from
May 12, 2021
Merged

fix(43879): for ( async of should be a syntax error #43886

merged 1 commit into from
May 12, 2021

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #43879

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Apr 29, 2021
sandersn
sandersn requested changes May 7, 2021
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request for tests based on @Zzzen 's comments.

tests/cases/conformance/parser/ecmascript6/Iterators/parserForOfStatement22.ts Show resolved Hide resolved
src/compiler/checker.ts Show resolved Hide resolved
@a-tarasyuk a-tarasyuk force-pushed the fix/43879 branch 2 times, most recently from 16b17c8 to 5404aad Compare May 8, 2021 18:32
@a-tarasyuk a-tarasyuk requested a review from sandersn May 8, 2021 18:53
sandersn
sandersn requested changes May 12, 2021
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more change -- I noticed that the error message is inconsistent.

src/compiler/diagnosticMessages.json Outdated Show resolved Hide resolved
src/compiler/checker.ts Show resolved Hide resolved
@a-tarasyuk a-tarasyuk requested a review from sandersn May 12, 2021 06:01
@sandersn sandersn merged commit 7aacd6b into microsoft:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zzzen Zzzen Zzzen left review comments

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

for ( async of should be a syntax error
4 participants
@a-tarasyuk @sandersn @Zzzen @typescript-bot