-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
During inference discriminate the target type before falling back to close-matching types #43853
Conversation
…close-matching types
@typescript-bot perf test this |
Heya @weswigham, I've started to run the tarball bundle task on this PR at d7ef49d. You can monitor the build here. |
Heya @weswigham, I've started to run the perf test suite on this PR at d7ef49d. You can monitor the build here. Update: The results are in! |
Heya @weswigham, I've started to run the extended test suite on this PR at d7ef49d. You can monitor the build here. |
Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at d7ef49d. You can monitor the build here. |
Heya @weswigham, I've started to run the parallelized community code test suite on this PR at d7ef49d. You can monitor the build here. |
Hey @weswigham, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build and an npm module you can use via |
@weswigham Here they are:Comparison Report - master..43853
System
Hosts
Scenarios
Developer Information: |
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
looks at performance results OK. Definitely needs better perf before this is a viable route to fix the linked issue. Union discrimination is expensive. |
I vote to close this since it sounds too slow to use as-is. Is that OK @weswigham ? |
Yeah, you're not wrong; I just can't immediately think of another way to fix the original issue (at least not one that doesn't totally overhaul inference, anyway), so trying to make this performant sounds like the best avenue to pursue. |
Fixes #43753