Enforce keyword order of abstract and override
#43829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
RyanCavanaugh
approved these changes
Apr 26, 2021
| } | ||
|
|
||
| abstract class Test5 extends Base { | ||
| override abstract m1(): void; // error |
There was a problem hiding this comment.
did you miss update to the test?
sheetalkamat
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More #43660
abstract overrideseems to be the conventional order in C#, Scala, and Kotlin, though it’s a little hard to search for since you get a lot of English phrases like “how to override abstract member.” But the vast majority of actual code samples that turn up seem to beabstract override.