Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only catalog types when tracing #43446

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Only catalog types when tracing #43446

merged 1 commit into from
Mar 31, 2021

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Mar 30, 2021

(cherry picked from commit 9fd2b48)

@amcasey
Only catalog types when tracing
0ac4f88 
(cherry picked from commit 9fd2b48)
@amcasey amcasey requested a review from RyanCavanaugh March 30, 2021 20:46
@amcasey
Copy link
Member Author

amcasey commented Mar 30, 2021

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 30, 2021 •
edited
Loading

Heya @amcasey, I've started to run the perf test suite on this PR at 0ac4f88. You can monitor the build here.

Update: The results are in!

@typescript-bot typescript-bot added For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 30, 2021
@amcasey
Copy link
Member Author

amcasey commented Mar 30, 2021

This is a memory usage win that seems safe enough for a patch release.

@typescript-bot
Copy link
Collaborator

@amcasey
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..43446

Metric master 43446 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 344,992k (± 0.02%) 341,409k (± 0.03%) -3,583k (- 1.04%) 341,252k 341,733k
Parse Time 1.95s (± 0.31%) 1.91s (± 0.53%) -0.04s (- 2.06%) 1.89s 1.93s
Bind Time 0.84s (± 0.74%) 0.82s (± 0.58%) -0.02s (- 1.91%) 0.81s 0.83s
Check Time 5.10s (± 0.33%) 4.94s (± 0.47%) 🟩-0.16s (- 3.12%) 4.91s 5.00s
Emit Time 5.92s (± 0.71%) 5.26s (± 0.73%) 🟩-0.66s (-11.16%) 5.18s 5.34s
Total Time 13.81s (± 0.38%) 12.93s (± 0.48%) 🟩-0.88s (- 6.35%) 12.81s 13.09s
Compiler-Unions - node (v10.16.3, x64)
Memory used 203,246k (± 0.02%) 213,639k (± 0.03%) +10,393k (+ 5.11%) 213,486k 213,749k
Parse Time 0.78s (± 0.85%) 0.78s (± 0.71%) -0.00s (- 0.26%) 0.77s 0.79s
Bind Time 0.53s (± 0.94%) 0.50s (± 1.20%) 🟩-0.03s (- 5.70%) 0.48s 0.51s
Check Time 7.53s (± 0.61%) 10.55s (± 0.79%) 🔻+3.02s (+40.12%) 10.40s 10.70s
Emit Time 2.60s (± 1.08%) 2.34s (± 1.06%) 🟩-0.26s (- 9.93%) 2.28s 2.40s
Total Time 11.43s (± 0.42%) 14.16s (± 0.62%) +2.73s (+23.87%) 14.03s 14.33s
Monaco - node (v10.16.3, x64)
Memory used 342,676k (± 0.03%) 340,838k (± 0.02%) -1,838k (- 0.54%) 340,751k 340,920k
Parse Time 1.56s (± 0.51%) 1.55s (± 0.29%) -0.01s (- 0.64%) 1.54s 1.56s
Bind Time 0.74s (± 0.46%) 0.72s (± 0.65%) -0.02s (- 2.31%) 0.71s 0.73s
Check Time 5.28s (± 0.71%) 5.08s (± 0.39%) 🟩-0.19s (- 3.64%) 5.06s 5.14s
Emit Time 3.15s (± 0.77%) 2.80s (± 0.61%) 🟩-0.34s (-10.97%) 2.76s 2.85s
Total Time 10.72s (± 0.47%) 10.16s (± 0.38%) 🟩-0.56s (- 5.22%) 10.08s 10.24s
TFS - node (v10.16.3, x64)
Memory used 304,226k (± 0.02%) 303,250k (± 0.02%) -976k (- 0.32%) 303,144k 303,384k
Parse Time 1.21s (± 0.74%) 1.21s (± 0.63%) -0.01s (- 0.74%) 1.19s 1.22s
Bind Time 0.70s (± 0.63%) 0.68s (± 0.53%) -0.02s (- 2.56%) 0.68s 0.69s
Check Time 4.73s (± 0.51%) 4.62s (± 0.29%) -0.11s (- 2.37%) 4.60s 4.65s
Emit Time 3.25s (± 1.07%) 2.93s (± 1.01%) 🟩-0.33s (-10.05%) 2.85s 2.97s
Total Time 9.90s (± 0.46%) 9.44s (± 0.37%) 🟩-0.46s (- 4.70%) 9.35s 9.49s
material-ui - node (v10.16.3, x64)
Memory used 465,615k (± 0.01%) 457,255k (± 0.01%) -8,360k (- 1.80%) 457,174k 457,340k
Parse Time 2.01s (± 0.51%) 1.99s (± 0.73%) -0.02s (- 1.19%) 1.95s 2.01s
Bind Time 0.65s (± 1.16%) 0.65s (± 0.73%) -0.00s (- 0.15%) 0.64s 0.66s
Check Time 14.19s (± 0.30%) 13.88s (± 0.77%) -0.32s (- 2.22%) 13.68s 14.17s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.86s (± 0.27%) 16.52s (± 0.63%) -0.34s (- 2.02%) 16.34s 16.82s
Angular - node (v12.1.0, x64)
Memory used 322,621k (± 0.02%) 319,069k (± 0.01%) -3,552k (- 1.10%) 318,986k 319,167k
Parse Time 1.93s (± 0.39%) 1.90s (± 0.46%) -0.04s (- 1.81%) 1.88s 1.92s
Bind Time 0.82s (± 0.73%) 0.80s (± 0.75%) -0.02s (- 2.33%) 0.79s 0.81s
Check Time 5.01s (± 0.51%) 4.83s (± 0.76%) 🟩-0.17s (- 3.46%) 4.78s 4.97s
Emit Time 5.98s (± 0.44%) 5.41s (± 0.93%) 🟩-0.57s (- 9.51%) 5.32s 5.57s
Total Time 13.73s (± 0.29%) 12.94s (± 0.50%) 🟩-0.79s (- 5.77%) 12.83s 13.08s
Compiler-Unions - node (v12.1.0, x64)
Memory used 190,506k (± 0.13%) 199,003k (± 0.09%) +8,497k (+ 4.46%) 198,583k 199,272k
Parse Time 0.77s (± 0.72%) 0.77s (± 0.72%) -0.00s (- 0.52%) 0.76s 0.78s
Bind Time 0.53s (± 1.27%) 0.50s (± 1.04%) 🟩-0.03s (- 5.31%) 0.49s 0.51s
Check Time 7.00s (± 0.96%) 9.52s (± 0.47%) 🔻+2.52s (+35.96%) 9.39s 9.60s
Emit Time 2.55s (± 0.88%) 2.34s (± 0.85%) 🟩-0.21s (- 8.08%) 2.30s 2.37s
Total Time 10.85s (± 0.70%) 13.12s (± 0.44%) +2.28s (+20.97%) 12.98s 13.23s
Monaco - node (v12.1.0, x64)
Memory used 325,061k (± 0.02%) 322,933k (± 0.09%) -2,128k (- 0.65%) 321,853k 323,292k
Parse Time 1.54s (± 0.85%) 1.54s (± 0.62%) -0.00s (- 0.32%) 1.52s 1.56s
Bind Time 0.72s (± 0.46%) 0.70s (± 0.47%) -0.02s (- 2.78%) 0.69s 0.71s
Check Time 5.10s (± 0.34%) 4.88s (± 0.51%) 🟩-0.21s (- 4.22%) 4.84s 4.94s
Emit Time 3.09s (± 0.70%) 2.85s (± 1.21%) 🟩-0.24s (- 7.86%) 2.80s 2.97s
Total Time 10.45s (± 0.39%) 9.96s (± 0.49%) 🟩-0.48s (- 4.64%) 9.90s 10.12s
TFS - node (v12.1.0, x64)
Memory used 288,763k (± 0.03%) 287,543k (± 0.02%) -1,220k (- 0.42%) 287,391k 287,636k
Parse Time 1.22s (± 0.83%) 1.22s (± 0.81%) +0.01s (+ 0.58%) 1.20s 1.25s
Bind Time 0.70s (± 0.71%) 0.65s (± 1.08%) 🟩-0.05s (- 6.75%) 0.64s 0.66s
Check Time 4.64s (± 0.48%) 4.48s (± 0.44%) 🟩-0.16s (- 3.47%) 4.45s 4.53s
Emit Time 3.16s (± 0.33%) 2.94s (± 0.78%) 🟩-0.23s (- 7.18%) 2.90s 3.02s
Total Time 9.71s (± 0.29%) 9.28s (± 0.29%) 🟩-0.43s (- 4.41%) 9.24s 9.34s
material-ui - node (v12.1.0, x64)
Memory used 443,528k (± 0.07%) 434,748k (± 0.02%) -8,780k (- 1.98%) 434,583k 434,877k
Parse Time 2.02s (± 0.37%) 1.98s (± 0.48%) -0.04s (- 2.03%) 1.96s 2.00s
Bind Time 0.65s (± 0.92%) 0.64s (± 1.04%) -0.01s (- 0.93%) 0.62s 0.65s
Check Time 12.88s (± 0.57%) 12.43s (± 0.71%) 🟩-0.45s (- 3.46%) 12.28s 12.63s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.55s (± 0.46%) 15.06s (± 0.58%) 🟩-0.49s (- 3.16%) 14.91s 15.26s
Angular - node (v14.15.1, x64)
Memory used 321,380k (± 0.01%) 317,622k (± 0.01%) -3,757k (- 1.17%) 317,586k 317,673k
Parse Time 1.93s (± 0.64%) 1.91s (± 0.25%) -0.02s (- 1.04%) 1.90s 1.92s
Bind Time 0.87s (± 0.87%) 0.85s (± 1.03%) -0.01s (- 1.50%) 0.84s 0.87s
Check Time 5.04s (± 0.55%) 4.85s (± 0.51%) 🟩-0.18s (- 3.67%) 4.80s 4.92s
Emit Time 6.33s (± 0.96%) 5.53s (± 0.83%) 🟩-0.80s (-12.63%) 5.45s 5.62s
Total Time 14.17s (± 0.60%) 13.15s (± 0.46%) 🟩-1.02s (- 7.22%) 13.04s 13.26s
Compiler-Unions - node (v14.15.1, x64)
Memory used 189,402k (± 0.01%) 199,069k (± 0.51%) +9,667k (+ 5.10%) 198,149k 202,048k
Parse Time 0.81s (± 1.03%) 0.80s (± 0.81%) -0.01s (- 0.87%) 0.79s 0.82s
Bind Time 0.56s (± 0.65%) 0.53s (± 0.42%) 🟩-0.02s (- 4.50%) 0.53s 0.54s
Check Time 7.08s (± 0.50%) 9.60s (± 0.39%) 🔻+2.52s (+35.66%) 9.54s 9.70s
Emit Time 2.54s (± 0.57%) 2.38s (± 1.41%) 🟩-0.16s (- 6.41%) 2.30s 2.46s
Total Time 10.98s (± 0.39%) 13.31s (± 0.45%) +2.32s (+21.16%) 13.16s 13.45s
Monaco - node (v14.15.1, x64)
Memory used 324,026k (± 0.01%) 322,379k (± 0.01%) -1,647k (- 0.51%) 322,329k 322,461k
Parse Time 1.58s (± 0.57%) 1.57s (± 0.59%) -0.01s (- 0.70%) 1.55s 1.59s
Bind Time 0.75s (± 1.16%) 0.74s (± 1.03%) -0.01s (- 1.60%) 0.72s 0.75s
Check Time 5.03s (± 0.70%) 4.85s (± 0.62%) 🟩-0.18s (- 3.59%) 4.81s 4.92s
Emit Time 3.17s (± 0.46%) 2.91s (± 0.71%) 🟩-0.26s (- 8.23%) 2.87s 2.96s
Total Time 10.53s (± 0.48%) 10.06s (± 0.46%) 🟩-0.47s (- 4.45%) 9.97s 10.17s
TFS - node (v14.15.1, x64)
Memory used 287,729k (± 0.01%) 286,735k (± 0.00%) -994k (- 0.35%) 286,712k 286,763k
Parse Time 1.28s (± 1.16%) 1.25s (± 1.47%) -0.03s (- 2.03%) 1.22s 1.29s
Bind Time 0.71s (± 0.69%) 0.70s (± 1.61%) -0.01s (- 2.10%) 0.68s 0.73s
Check Time 4.69s (± 0.46%) 4.49s (± 0.28%) 🟩-0.19s (- 4.14%) 4.46s 4.52s
Emit Time 3.26s (± 0.42%) 3.03s (± 0.49%) 🟩-0.23s (- 7.20%) 3.01s 3.06s
Total Time 9.94s (± 0.36%) 9.48s (± 0.34%) 🟩-0.47s (- 4.71%) 9.43s 9.55s
material-ui - node (v14.15.1, x64)
Memory used 441,875k (± 0.05%) 433,486k (± 0.01%) -8,390k (- 1.90%) 433,436k 433,550k
Parse Time 2.09s (± 0.32%) 2.06s (± 0.46%) -0.03s (- 1.24%) 2.04s 2.08s
Bind Time 0.69s (± 0.96%) 0.70s (± 0.84%) +0.01s (+ 1.59%) 0.69s 0.71s
Check Time 13.06s (± 0.85%) 12.54s (± 0.67%) 🟩-0.52s (- 3.98%) 12.41s 12.77s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.84s (± 0.71%) 15.31s (± 0.55%) 🟩-0.53s (- 3.33%) 15.18s 15.56s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-206-generic
Architecturex64
Available Memory16 GB
Available Memory10 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 43446 10
Baseline master 10

@amcasey
Copy link
Member Author

amcasey commented Mar 30, 2021 •
edited
Loading

I really don't see how this could regress check time by 40%, especially since the same PR in master did not. However, I'll investigate.

master perf results: #43304 (comment)

Edit: These numbers don't make any sense. Even if some weird de-opt effect hurt check time, I definitely didn't improve emit time. This should affect memory usage and nothing else. Maybe the baselines are off?

Edit 2: That's because the baseline is master. 🤦‍♂️

@amcasey
Copy link
Member Author

amcasey commented Mar 30, 2021

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 30, 2021 •
edited
Loading

Heya @amcasey, I've started to run the perf test suite on this PR at 0ac4f88. You can monitor the build here.

Update: The results are in!

@amcasey
Copy link
Member Author

amcasey commented Mar 30, 2021

So I guess the perf results actually show that this PR closes the memory perf gap that existed between release-4.2 and master.

@typescript-bot
Copy link
Collaborator

@amcasey
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..43446

Metric master 43446 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 344,945k (± 0.02%) 341,420k (± 0.02%) -3,525k (- 1.02%) 341,304k 341,609k
Parse Time 1.94s (± 0.64%) 1.91s (± 0.58%) -0.03s (- 1.59%) 1.89s 1.94s
Bind Time 0.83s (± 0.57%) 0.82s (± 0.57%) -0.01s (- 1.56%) 0.81s 0.83s
Check Time 5.12s (± 0.56%) 4.93s (± 0.39%) 🟩-0.19s (- 3.62%) 4.89s 4.98s
Emit Time 5.93s (± 0.68%) 5.27s (± 0.64%) 🟩-0.66s (-11.16%) 5.22s 5.38s
Total Time 13.82s (± 0.45%) 12.94s (± 0.43%) 🟩-0.89s (- 6.43%) 12.83s 13.10s
Compiler-Unions - node (v10.16.3, x64)
Memory used 203,187k (± 0.11%) 213,430k (± 0.09%) +10,242k (+ 5.04%) 213,004k 213,719k
Parse Time 0.79s (± 0.74%) 0.78s (± 0.77%) -0.01s (- 1.52%) 0.76s 0.79s
Bind Time 0.52s (± 1.43%) 0.49s (± 1.63%) 🟩-0.03s (- 5.38%) 0.48s 0.51s
Check Time 7.45s (± 0.57%) 10.54s (± 0.66%) 🔻+3.09s (+41.43%) 10.46s 10.73s
Emit Time 2.60s (± 0.82%) 2.35s (± 1.11%) 🟩-0.25s (- 9.66%) 2.31s 2.41s
Total Time 11.36s (± 0.41%) 14.16s (± 0.54%) +2.80s (+24.65%) 14.04s 14.31s
Monaco - node (v10.16.3, x64)
Memory used 342,675k (± 0.02%) 340,818k (± 0.02%) -1,857k (- 0.54%) 340,678k 341,030k
Parse Time 1.56s (± 0.54%) 1.55s (± 0.58%) -0.01s (- 0.51%) 1.53s 1.58s
Bind Time 0.74s (± 0.87%) 0.72s (± 0.82%) -0.02s (- 2.43%) 0.71s 0.73s
Check Time 5.25s (± 0.36%) 5.09s (± 0.58%) 🟩-0.16s (- 3.03%) 5.02s 5.17s
Emit Time 3.12s (± 0.59%) 2.79s (± 1.14%) 🟩-0.33s (-10.42%) 2.73s 2.88s
Total Time 10.66s (± 0.33%) 10.15s (± 0.53%) 🟩-0.51s (- 4.78%) 10.05s 10.27s
TFS - node (v10.16.3, x64)
Memory used 304,307k (± 0.03%) 303,276k (± 0.03%) -1,032k (- 0.34%) 303,049k 303,407k
Parse Time 1.21s (± 0.51%) 1.21s (± 0.48%) -0.00s (- 0.17%) 1.20s 1.22s
Bind Time 0.70s (± 0.67%) 0.68s (± 0.59%) 🟩-0.02s (- 3.00%) 0.67s 0.69s
Check Time 4.74s (± 0.45%) 4.61s (± 0.65%) -0.13s (- 2.74%) 4.51s 4.65s
Emit Time 3.27s (± 1.60%) 2.94s (± 0.73%) 🟩-0.33s (-10.03%) 2.91s 3.00s
Total Time 9.92s (± 0.55%) 9.44s (± 0.45%) 🟩-0.48s (- 4.86%) 9.30s 9.52s
material-ui - node (v10.16.3, x64)
Memory used 465,420k (± 0.01%) 457,249k (± 0.01%) -8,171k (- 1.76%) 457,158k 457,328k
Parse Time 2.02s (± 0.52%) 1.97s (± 0.53%) -0.04s (- 2.23%) 1.96s 2.01s
Bind Time 0.66s (± 1.26%) 0.65s (± 1.39%) -0.01s (- 0.76%) 0.64s 0.68s
Check Time 14.28s (± 0.68%) 13.85s (± 0.51%) -0.42s (- 2.97%) 13.73s 14.08s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.95s (± 0.57%) 16.48s (± 0.49%) -0.48s (- 2.81%) 16.35s 16.76s
Angular - node (v12.1.0, x64)
Memory used 322,707k (± 0.02%) 319,045k (± 0.03%) -3,662k (- 1.13%) 318,760k 319,303k
Parse Time 1.92s (± 0.70%) 1.90s (± 0.67%) -0.02s (- 1.20%) 1.86s 1.92s
Bind Time 0.82s (± 1.03%) 0.80s (± 1.23%) -0.02s (- 2.56%) 0.78s 0.83s
Check Time 5.02s (± 0.44%) 4.81s (± 0.24%) 🟩-0.21s (- 4.21%) 4.77s 4.83s
Emit Time 5.97s (± 0.63%) 5.38s (± 0.68%) 🟩-0.59s (- 9.88%) 5.33s 5.50s
Total Time 13.73s (± 0.47%) 12.88s (± 0.33%) 🟩-0.85s (- 6.17%) 12.82s 13.00s
Compiler-Unions - node (v12.1.0, x64)
Memory used 190,554k (± 0.09%) 198,996k (± 0.05%) +8,442k (+ 4.43%) 198,632k 199,143k
Parse Time 0.78s (± 0.48%) 0.76s (± 0.62%) -0.02s (- 1.94%) 0.75s 0.77s
Bind Time 0.53s (± 0.94%) 0.50s (± 0.99%) 🟩-0.03s (- 5.70%) 0.49s 0.51s
Check Time 6.97s (± 0.58%) 9.51s (± 0.38%) 🔻+2.54s (+36.46%) 9.46s 9.59s
Emit Time 2.53s (± 0.78%) 2.34s (± 1.02%) 🟩-0.19s (- 7.36%) 2.30s 2.39s
Total Time 10.80s (± 0.50%) 13.11s (± 0.31%) +2.31s (+21.41%) 13.04s 13.24s
Monaco - node (v12.1.0, x64)
Memory used 325,137k (± 0.03%) 323,048k (± 0.02%) -2,089k (- 0.64%) 322,933k 323,161k
Parse Time 1.54s (± 0.66%) 1.54s (± 0.64%) +0.00s (+ 0.19%) 1.53s 1.57s
Bind Time 0.72s (± 0.62%) 0.70s (± 0.80%) -0.02s (- 2.79%) 0.69s 0.71s
Check Time 5.10s (± 0.43%) 4.87s (± 0.35%) 🟩-0.23s (- 4.56%) 4.84s 4.90s
Emit Time 3.10s (± 0.48%) 2.83s (± 0.57%) 🟩-0.27s (- 8.56%) 2.80s 2.88s
Total Time 10.46s (± 0.33%) 9.95s (± 0.29%) 🟩-0.51s (- 4.89%) 9.87s 10.00s
TFS - node (v12.1.0, x64)
Memory used 288,777k (± 0.02%) 287,553k (± 0.02%) -1,224k (- 0.42%) 287,437k 287,647k
Parse Time 1.21s (± 0.73%) 1.22s (± 0.57%) +0.01s (+ 0.41%) 1.21s 1.24s
Bind Time 0.69s (± 0.86%) 0.65s (± 0.80%) 🟩-0.04s (- 6.48%) 0.64s 0.66s
Check Time 4.65s (± 0.31%) 4.49s (± 0.60%) 🟩-0.16s (- 3.46%) 4.40s 4.54s
Emit Time 3.17s (± 0.97%) 2.92s (± 0.47%) 🟩-0.25s (- 7.83%) 2.90s 2.95s
Total Time 9.72s (± 0.39%) 9.28s (± 0.29%) 🟩-0.45s (- 4.58%) 9.22s 9.32s
material-ui - node (v12.1.0, x64)
Memory used 443,345k (± 0.08%) 434,792k (± 0.02%) -8,553k (- 1.93%) 434,652k 435,079k
Parse Time 2.03s (± 0.57%) 1.98s (± 0.38%) -0.04s (- 2.02%) 1.97s 2.00s
Bind Time 0.64s (± 0.74%) 0.64s (± 0.73%) -0.00s (- 0.47%) 0.63s 0.65s
Check Time 12.97s (± 0.96%) 12.43s (± 0.71%) 🟩-0.53s (- 4.11%) 12.27s 12.71s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.64s (± 0.84%) 15.06s (± 0.58%) 🟩-0.58s (- 3.70%) 14.89s 15.33s
Angular - node (v14.15.1, x64)
Memory used 321,373k (± 0.01%) 317,530k (± 0.08%) -3,844k (- 1.20%) 316,555k 317,678k
Parse Time 1.93s (± 0.53%) 1.91s (± 0.52%) -0.02s (- 1.14%) 1.89s 1.93s
Bind Time 0.86s (± 0.75%) 0.84s (± 0.70%) -0.01s (- 1.63%) 0.83s 0.86s
Check Time 5.02s (± 0.45%) 4.85s (± 0.84%) 🟩-0.17s (- 3.33%) 4.79s 5.00s
Emit Time 6.32s (± 0.54%) 5.49s (± 0.61%) 🟩-0.83s (-13.17%) 5.41s 5.57s
Total Time 14.13s (± 0.35%) 13.09s (± 0.44%) 🟩-1.03s (- 7.31%) 12.98s 13.30s
Compiler-Unions - node (v14.15.1, x64)
Memory used 189,413k (± 0.01%) 198,685k (± 0.34%) +9,272k (+ 4.90%) 198,100k 201,311k
Parse Time 0.80s (± 0.88%) 0.80s (± 0.60%) -0.00s (- 0.25%) 0.79s 0.81s
Bind Time 0.56s (± 0.65%) 0.53s (± 1.04%) 🟩-0.02s (- 4.32%) 0.52s 0.55s
Check Time 7.05s (± 0.53%) 9.55s (± 0.32%) 🔻+2.50s (+35.48%) 9.48s 9.62s
Emit Time 2.56s (± 0.55%) 2.39s (± 1.02%) 🟩-0.17s (- 6.49%) 2.34s 2.43s
Total Time 10.96s (± 0.40%) 13.27s (± 0.31%) +2.31s (+21.07%) 13.18s 13.37s
Monaco - node (v14.15.1, x64)
Memory used 324,070k (± 0.00%) 322,367k (± 0.01%) -1,703k (- 0.53%) 322,344k 322,410k
Parse Time 1.57s (± 0.37%) 1.56s (± 0.76%) -0.01s (- 0.57%) 1.54s 1.58s
Bind Time 0.74s (± 0.75%) 0.73s (± 0.79%) -0.01s (- 1.21%) 0.72s 0.75s
Check Time 5.06s (± 0.27%) 4.84s (± 0.40%) 🟩-0.22s (- 4.37%) 4.80s 4.88s
Emit Time 3.19s (± 0.61%) 2.92s (± 0.82%) 🟩-0.27s (- 8.48%) 2.87s 2.98s
Total Time 10.56s (± 0.27%) 10.05s (± 0.45%) 🟩-0.51s (- 4.79%) 9.96s 10.17s
TFS - node (v14.15.1, x64)
Memory used 287,702k (± 0.00%) 286,720k (± 0.01%) -982k (- 0.34%) 286,679k 286,754k
Parse Time 1.26s (± 0.88%) 1.25s (± 0.69%) -0.01s (- 0.72%) 1.23s 1.27s
Bind Time 0.72s (± 0.69%) 0.69s (± 0.68%) 🟩-0.03s (- 3.63%) 0.68s 0.70s
Check Time 4.68s (± 0.61%) 4.49s (± 0.51%) 🟩-0.19s (- 4.04%) 4.45s 4.56s
Emit Time 3.26s (± 0.81%) 3.05s (± 1.14%) 🟩-0.21s (- 6.41%) 2.97s 3.15s
Total Time 9.91s (± 0.41%) 9.48s (± 0.48%) 🟩-0.43s (- 4.38%) 9.36s 9.56s
material-ui - node (v14.15.1, x64)
Memory used 441,721k (± 0.06%) 433,380k (± 0.06%) -8,341k (- 1.89%) 432,257k 433,580k
Parse Time 2.10s (± 0.81%) 2.06s (± 0.59%) -0.04s (- 2.09%) 2.04s 2.09s
Bind Time 0.69s (± 0.52%) 0.70s (± 0.83%) +0.01s (+ 1.30%) 0.69s 0.71s
Check Time 13.07s (± 0.62%) 12.50s (± 0.62%) 🟩-0.57s (- 4.34%) 12.34s 12.75s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.86s (± 0.59%) 15.27s (± 0.54%) 🟩-0.60s (- 3.76%) 15.08s 15.52s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-206-generic
Architecturex64
Available Memory16 GB
Available Memory10 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 43446 10
Baseline master 10

@amcasey amcasey merged commit 6b33949 into microsoft:release-4.2 Mar 31, 2021
@amcasey amcasey deleted the Catalog42 branch March 31, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees

@amcasey amcasey

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amcasey @typescript-bot @RyanCavanaugh