Emit export declarations in place #4259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
| } | ||
| //let defaultName = |
|
Isn't the following now broken? export { foo };
var foo = 1;The reason we emit the export assignment right after the variable declaration is that the export declaration might occur anywhere in the file. Also, there might be more than one export declaration for a particular variable (e.g. to export the same variable by different names), but ideally we only want to generate one export assignment. |
|
@ahejlsberg : as @mhegazy pointed out wouldn't it be easier to fix this since user has workaround for it than the bug its fixing right now. There is no work around for the current scenario. |
|
This should not be needed any longer. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4101 and #4004