Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only when typings file change for the project, schedule the update for the project #42428

Merged
merged 3 commits into from
Jan 22, 2021

Conversation

sheetalkamat
Copy link
Member

This avoids unnecessary project updates, project updated in background on which editor normally sends error request so multiple program updates and unnecessarily invalidating resolutions is avoided.
Fixes #39326

@sheetalkamat
Copy link
Member Author

@typescript-bot pack this

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jan 21, 2021
@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 21, 2021

Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at 6d543ea. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 21, 2021

Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/93822/artifacts?artifactName=tgz&fileId=C2CB9F255EE3292BA69CCD1F39BED9A6DE2BCEA1815B72ACC1B42EC063ABD0C102&fileName=/typescript-4.2.0-insiders.20210121.tgz"
    }
}

and then running npm install.


There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

@Bluefitdev
Copy link

Working, thanks so much!

@sheetalkamat sheetalkamat requested review from amcasey, jessetrinity and RyanCavanaugh and removed request for amcasey January 21, 2021 20:14
@jessetrinity
Copy link
Contributor

Are there any scenarios we should expect to be affected in VS besides adding new typings? I don't foresee any issues in that case.

Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@sheetalkamat
Copy link
Member Author

No it just improves when the program updates in background in tsserver so technically nothing should change apart from better perf with respect to avoiding unnecessary updates.

@sheetalkamat sheetalkamat merged commit 80dfc6a into master Jan 22, 2021
@sheetalkamat sheetalkamat deleted the setTypings branch January 22, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intellisense stuck on loading after trying to index absolute import
5 participants