Adds Format param to the tsserver session #41614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary |
typescript-bot
added
Author: Team
For Uncommitted Bug
sheetalkamat
approved these changes
Nov 20, 2020
|
Thanks sheetal! |
|
May be we need this for 4.1 patch as well ? |
mjbvz
reviewed
Nov 20, 2020
| /** | ||
| * Optional for backwards compat, use "2020" for modern LSP-like classifications | ||
| */ | ||
| format?: ts.SemanticClassificationFormat |
There was a problem hiding this comment.
@orta Just want to check that this will also update the protocol.d.ts file that we consume. I didn't see the semantic APIs in the d.ts when I last checked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should unblock #41262 - the param
format?was introduced to the tsserver API in #38435 . In order to be used by vscode, it needs to be exposed via the session.ts and protocol.ts.Which is what this PR does, it also adds some extra values to some of the types in the protocol.