Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(15230): "Cannot compile namespaces" error with --isolatedModules and no namespaces #40032

Merged
merged 1 commit into from
Aug 13, 2020
Merged

fix(15230): "Cannot compile namespaces" error with --isolatedModules and no namespaces #40032

merged 1 commit into from
Aug 13, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #15230

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Aug 13, 2020
sandersn
sandersn requested changes Aug 13, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 'global' is still a slightly jargon-ish term, but I don't know a better one.
  2. I think we can cut the error down slightly if the error is always in a non-module file.

src/compiler/diagnosticMessages.json Outdated Show resolved Hide resolved
@DanielRosenwasser DanielRosenwasser merged commit edc88c5 into microsoft:master Aug 13, 2020
@jakebailey jakebailey mentioned this pull request Jul 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@sandersn sandersn Awaiting requested review from sandersn

Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Cannot compile namespaces" error with --isolatedModules and no namespaces
4 participants
@a-tarasyuk @sandersn @DanielRosenwasser @typescript-bot