Use isUncalledFunctionReference for aliases too #39950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bogus deprecated notices on imports of functions with deprecated overloads, but with some non-deprecated overloads. Fixes microsoft/vscode#104238
typescript-bot
added
Author: Team
For Uncommitted Bug
|
@Kingwl you probably want to see this too. |
andrewbranch
approved these changes
Aug 7, 2020
|
@typescript-bot cherry-pick this to release-4.0 |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Aug 7, 2020
sandersn
added a commit
that referenced
this pull request
Aug 7, 2020
Component commits: 6e5d75b Use isUncalledFunctionReference for aliases too Fixes bogus deprecated notices on imports of functions with deprecated overloads, but with some non-deprecated overloads. Fixes microsoft/vscode#104238 e2eb319 Just check all declarations, don't call isUncalledFunction Co-authored-by: Nathan Shively-Sanders <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bogus deprecated notices on imports of functions with deprecated overloads, but with some non-deprecated overloads.
This should ship in 4.0 too.
Fixes microsoft/vscode#104238