Use a single relation stack for nested dependent variance calculations

[weswigham]

Fixes #39059

[weswigham]

@typescript-bot user test this
@typescript-bot test this
@typescript-bot run dt
@typescript-bot perf test this

[typescript-bot]

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at c9e57e1. You can monitor the build here.

[typescript-bot]

Heya @weswigham, I've started to run the extended test suite on this PR at c9e57e1. You can monitor the build here.

[typescript-bot]

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at c9e57e1. You can monitor the build here.

[typescript-bot]

Heya @weswigham, I've started to run the perf test suite on this PR at c9e57e1. You can monitor the build here.

Update: The results are in!

[typescript-bot]

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

[typescript-bot]

@weswigham
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..39232

Metric	master	39232	Delta	Best	Worst
Angular - node (v10.16.3, x64)
Memory used	340,499k (± 0.02%)	339,983k (± 0.02%)	-516k (- 0.15%)	339,832k	340,107k
Parse Time	1.99s (± 0.72%)	1.99s (± 0.67%)	+0.00s (+ 0.05%)	1.97s	2.03s
Bind Time	0.82s (± 0.82%)	0.82s (± 1.20%)	+0.00s (+ 0.12%)	0.80s	0.85s
Check Time	4.72s (± 0.54%)	4.74s (± 0.58%)	+0.01s (+ 0.28%)	4.68s	4.81s
Emit Time	5.18s (± 0.68%)	5.19s (± 0.65%)	+0.01s (+ 0.17%)	5.13s	5.29s
Total Time	12.72s (± 0.53%)	12.74s (± 0.39%)	+0.03s (+ 0.20%)	12.68s	12.87s
Monaco - node (v10.16.3, x64)
Memory used	338,967k (± 0.03%)	339,074k (± 0.04%)	+106k (+ 0.03%)	338,782k	339,279k
Parse Time	1.58s (± 0.84%)	1.58s (± 0.42%)	-0.00s (- 0.19%)	1.57s	1.59s
Bind Time	0.71s (± 0.66%)	0.71s (± 0.73%)	+0.00s (+ 0.14%)	0.70s	0.72s
Check Time	4.84s (± 0.54%)	4.84s (± 0.56%)	+0.00s (+ 0.08%)	4.80s	4.91s
Emit Time	2.74s (± 0.42%)	2.74s (± 0.54%)	-0.00s (- 0.07%)	2.71s	2.78s
Total Time	9.87s (± 0.39%)	9.87s (± 0.31%)	+0.00s (+ 0.03%)	9.80s	9.96s
TFS - node (v10.16.3, x64)
Memory used	301,981k (± 0.03%)	301,987k (± 0.02%)	+7k (+ 0.00%)	301,866k	302,091k
Parse Time	1.21s (± 0.73%)	1.22s (± 0.60%)	+0.01s (+ 0.41%)	1.21s	1.24s
Bind Time	0.66s (± 1.43%)	0.66s (± 1.42%)	-0.00s (- 0.30%)	0.64s	0.68s
Check Time	4.35s (± 0.50%)	4.36s (± 0.46%)	+0.01s (+ 0.25%)	4.32s	4.41s
Emit Time	2.90s (± 0.98%)	2.89s (± 0.99%)	-0.01s (- 0.48%)	2.83s	2.94s
Total Time	9.13s (± 0.49%)	9.13s (± 0.31%)	-0.00s (- 0.04%)	9.07s	9.20s
material-ui - node (v10.16.3, x64)
Memory used	459,762k (± 0.01%)	458,949k (± 0.01%)	-813k (- 0.18%)	458,860k	459,047k
Parse Time	2.05s (± 0.60%)	2.04s (± 0.61%)	-0.01s (- 0.39%)	2.02s	2.07s
Bind Time	0.66s (± 1.47%)	0.66s (± 0.72%)	+0.00s (+ 0.61%)	0.65s	0.67s
Check Time	12.93s (± 0.76%)	12.78s (± 0.52%)	-0.15s (- 1.14%)	12.66s	12.99s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	15.64s (± 0.69%)	15.48s (± 0.44%)	-0.15s (- 0.97%)	15.36s	15.68s
Angular - node (v12.1.0, x64)
Memory used	317,868k (± 0.02%)	317,432k (± 0.02%)	-436k (- 0.14%)	317,318k	317,536k
Parse Time	1.97s (± 0.70%)	1.96s (± 0.54%)	-0.01s (- 0.56%)	1.93s	1.98s
Bind Time	0.80s (± 0.95%)	0.80s (± 0.70%)	+0.00s (+ 0.25%)	0.79s	0.81s
Check Time	4.60s (± 0.38%)	4.59s (± 0.28%)	-0.01s (- 0.26%)	4.57s	4.62s
Emit Time	5.33s (± 0.65%)	5.33s (± 0.51%)	-0.01s (- 0.13%)	5.26s	5.38s
Total Time	12.70s (± 0.32%)	12.67s (± 0.33%)	-0.03s (- 0.24%)	12.56s	12.76s
Monaco - node (v12.1.0, x64)
Memory used	321,477k (± 0.02%)	321,484k (± 0.02%)	+7k (+ 0.00%)	321,347k	321,653k
Parse Time	1.56s (± 0.51%)	1.55s (± 0.56%)	-0.01s (- 0.39%)	1.53s	1.57s
Bind Time	0.69s (± 0.65%)	0.68s (± 0.54%)	-0.00s (- 0.44%)	0.68s	0.69s
Check Time	4.64s (± 0.45%)	4.67s (± 0.52%)	+0.03s (+ 0.60%)	4.59s	4.71s
Emit Time	2.81s (± 0.58%)	2.82s (± 0.92%)	+0.02s (+ 0.57%)	2.77s	2.89s
Total Time	9.70s (± 0.38%)	9.73s (± 0.48%)	+0.04s (+ 0.38%)	9.62s	9.86s
TFS - node (v12.1.0, x64)
Memory used	286,452k (± 0.03%)	286,450k (± 0.02%)	-2k (- 0.00%)	286,356k	286,629k
Parse Time	1.24s (± 1.01%)	1.24s (± 0.66%)	+0.00s (+ 0.24%)	1.23s	1.26s
Bind Time	0.64s (± 0.81%)	0.64s (± 0.81%)	0.00s ( 0.00%)	0.63s	0.65s
Check Time	4.28s (± 0.44%)	4.28s (± 0.43%)	+0.00s (+ 0.07%)	4.25s	4.32s
Emit Time	2.91s (± 0.61%)	2.94s (± 0.58%)	+0.02s (+ 0.86%)	2.89s	2.97s
Total Time	9.06s (± 0.41%)	9.09s (± 0.16%)	+0.03s (+ 0.34%)	9.07s	9.12s
material-ui - node (v12.1.0, x64)
Memory used	438,135k (± 0.01%)	437,377k (± 0.01%)	-758k (- 0.17%)	437,298k	437,465k
Parse Time	2.03s (± 0.34%)	2.01s (± 0.32%)	-0.02s (- 0.89%)	2.00s	2.02s
Bind Time	0.63s (± 0.94%)	0.63s (± 0.79%)	-0.01s (- 1.26%)	0.62s	0.64s
Check Time	11.61s (± 0.72%)	11.53s (± 1.08%)	-0.08s (- 0.65%)	11.37s	11.85s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	14.27s (± 0.60%)	14.17s (± 0.88%)	-0.10s (- 0.69%)	14.01s	14.50s
Angular - node (v8.9.0, x64)
Memory used	337,039k (± 0.01%)	336,599k (± 0.01%)	-439k (- 0.13%)	336,506k	336,656k
Parse Time	2.50s (± 0.48%)	2.50s (± 0.50%)	-0.01s (- 0.24%)	2.47s	2.53s
Bind Time	0.85s (± 0.58%)	0.84s (± 0.56%)	-0.01s (- 0.71%)	0.83s	0.85s
Check Time	5.36s (± 0.53%)	5.36s (± 0.79%)	+0.00s (+ 0.07%)	5.25s	5.45s
Emit Time	5.86s (± 1.46%)	5.89s (± 0.88%)	+0.03s (+ 0.56%)	5.72s	5.98s
Total Time	14.56s (± 0.75%)	14.59s (± 0.52%)	+0.02s (+ 0.17%)	14.38s	14.71s
Monaco - node (v8.9.0, x64)
Memory used	340,355k (± 0.02%)	340,410k (± 0.02%)	+55k (+ 0.02%)	340,293k	340,527k
Parse Time	1.87s (± 0.40%)	1.87s (± 0.35%)	-0.00s (- 0.27%)	1.85s	1.88s
Bind Time	0.88s (± 0.63%)	0.88s (± 0.34%)	-0.00s (- 0.45%)	0.87s	0.88s
Check Time	5.39s (± 0.50%)	5.37s (± 0.63%)	-0.02s (- 0.43%)	5.32s	5.46s
Emit Time	3.23s (± 0.66%)	3.21s (± 0.34%)	-0.02s (- 0.59%)	3.18s	3.23s
Total Time	11.37s (± 0.39%)	11.32s (± 0.39%)	-0.05s (- 0.44%)	11.26s	11.44s
TFS - node (v8.9.0, x64)
Memory used	303,715k (± 0.01%)	303,699k (± 0.02%)	-16k (- 0.01%)	303,555k	303,855k
Parse Time	1.54s (± 0.50%)	1.54s (± 0.70%)	+0.00s (+ 0.00%)	1.51s	1.56s
Bind Time	0.66s (± 0.89%)	0.67s (± 1.14%)	+0.00s (+ 0.30%)	0.65s	0.68s
Check Time	4.97s (± 1.64%)	4.96s (± 1.88%)	-0.01s (- 0.20%)	4.80s	5.15s
Emit Time	3.09s (± 2.20%)	3.05s (± 3.18%)	-0.04s (- 1.23%)	2.86s	3.22s
Total Time	10.26s (± 0.41%)	10.21s (± 0.54%)	-0.04s (- 0.41%)	10.11s	10.34s
material-ui - node (v8.9.0, x64)
Memory used	463,932k (± 0.01%)	463,233k (± 0.02%)	-699k (- 0.15%)	463,033k	463,349k
Parse Time	2.39s (± 0.48%)	2.38s (± 0.58%)	-0.00s (- 0.13%)	2.34s	2.41s
Bind Time	0.77s (± 0.88%)	0.77s (± 1.07%)	+0.00s (+ 0.00%)	0.76s	0.79s
Check Time	17.13s (± 1.00%)	17.14s (± 0.59%)	+0.01s (+ 0.03%)	16.98s	17.42s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	20.29s (± 0.86%)	20.30s (± 0.49%)	+0.00s (+ 0.01%)	20.15s	20.59s
Angular - node (v8.9.0, x86)
Memory used	193,501k (± 0.02%)	193,316k (± 0.02%)	-186k (- 0.10%)	193,260k	193,452k
Parse Time	2.43s (± 0.65%)	2.42s (± 0.72%)	-0.01s (- 0.21%)	2.38s	2.47s
Bind Time	0.97s (± 1.24%)	0.97s (± 0.85%)	-0.00s (- 0.10%)	0.96s	0.99s
Check Time	4.78s (± 0.70%)	4.79s (± 0.95%)	+0.01s (+ 0.19%)	4.72s	4.90s
Emit Time	5.86s (± 0.75%)	5.91s (± 0.71%)	+0.04s (+ 0.72%)	5.86s	6.06s
Total Time	14.05s (± 0.41%)	14.10s (± 0.58%)	+0.05s (+ 0.33%)	13.93s	14.32s
Monaco - node (v8.9.0, x86)
Memory used	193,373k (± 0.02%)	193,412k (± 0.02%)	+40k (+ 0.02%)	193,336k	193,473k
Parse Time	1.90s (± 0.61%)	1.91s (± 0.90%)	+0.01s (+ 0.26%)	1.88s	1.95s
Bind Time	0.70s (± 0.67%)	0.70s (± 0.83%)	-0.00s (- 0.43%)	0.69s	0.71s
Check Time	5.47s (± 0.70%)	5.49s (± 0.59%)	+0.01s (+ 0.27%)	5.43s	5.56s
Emit Time	2.66s (± 1.14%)	2.65s (± 0.52%)	-0.00s (- 0.19%)	2.63s	2.69s
Total Time	10.74s (± 0.46%)	10.75s (± 0.49%)	+0.01s (+ 0.12%)	10.66s	10.87s
TFS - node (v8.9.0, x86)
Memory used	173,660k (± 0.03%)	173,634k (± 0.02%)	-26k (- 0.01%)	173,556k	173,744k
Parse Time	1.58s (± 0.78%)	1.58s (± 0.56%)	+0.01s (+ 0.32%)	1.56s	1.60s
Bind Time	0.64s (± 0.58%)	0.64s (± 0.70%)	+0.00s (+ 0.47%)	0.63s	0.65s
Check Time	4.63s (± 0.61%)	4.64s (± 0.97%)	+0.01s (+ 0.32%)	4.54s	4.80s
Emit Time	2.80s (± 1.05%)	2.80s (± 1.26%)	+0.01s (+ 0.21%)	2.76s	2.91s
Total Time	9.64s (± 0.48%)	9.66s (± 0.71%)	+0.03s (+ 0.26%)	9.54s	9.88s
material-ui - node (v8.9.0, x86)
Memory used	262,667k (± 0.02%)	262,265k (± 0.01%)	-403k (- 0.15%)	262,201k	262,358k
Parse Time	2.46s (± 0.83%)	2.45s (± 0.96%)	-0.01s (- 0.49%)	2.41s	2.51s
Bind Time	0.67s (± 1.22%)	0.67s (± 1.51%)	-0.00s (- 0.15%)	0.65s	0.69s
Check Time	15.70s (± 0.78%)	15.53s (± 0.56%)	-0.17s (- 1.11%)	15.34s	15.73s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	18.84s (± 0.66%)	18.65s (± 0.44%)	-0.19s (- 1.01%)	18.47s	18.85s

System

Machine Name	ts-ci-ubuntu
Platform	linux 4.4.0-166-generic
Architecture	x64
Available Memory	16 GB
Available Memory	1 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v10.16.3, x64)
• node (v12.1.0, x64)
• node (v8.9.0, x64)
• node (v8.9.0, x86)

Scenarios

• Angular - node (v10.16.3, x64)
• Angular - node (v12.1.0, x64)
• Angular - node (v8.9.0, x64)
• Angular - node (v8.9.0, x86)
• Monaco - node (v10.16.3, x64)
• Monaco - node (v12.1.0, x64)
• Monaco - node (v8.9.0, x64)
• Monaco - node (v8.9.0, x86)
• TFS - node (v10.16.3, x64)
• TFS - node (v12.1.0, x64)
• TFS - node (v8.9.0, x64)
• TFS - node (v8.9.0, x86)
• material-ui - node (v10.16.3, x64)
• material-ui - node (v12.1.0, x64)
• material-ui - node (v8.9.0, x64)
• material-ui - node (v8.9.0, x86)

Benchmark	Name	Iterations
Current	39232	10
Baseline	master	10

[weswigham]

Hm, perf is good, but looks like RWC has an example where the failure to invalidate the Maybe result in variance analysis results in a bogus final comparison result (as I predicted in the comment in the code) - I'll need to distill it into an isolated example, somehow, so I can add it to the test suite.

[weswigham]

@typescript-bot user test this
@typescript-bot test this
@typescript-bot run dt
@typescript-bot perf test this

This modified fix passes RWC locally, but might have some perf impact, since it utilizes Unmeasurable - rerunning checks to find out.

[typescript-bot]

Heya @weswigham, I've started to run the extended test suite on this PR at 53a7560. You can monitor the build here.

[typescript-bot]

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 53a7560. You can monitor the build here.

[typescript-bot]

Heya @weswigham, I've started to run the perf test suite on this PR at 53a7560. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 53a7560. You can monitor the build here.

[typescript-bot]

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

[typescript-bot]

@weswigham
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..39232

Metric	master	39232	Delta	Best	Worst
Angular - node (v10.16.3, x64)
Memory used	343,642k (± 0.02%)	343,270k (± 0.02%)	-372k (- 0.11%)	343,089k	343,412k
Parse Time	2.02s (± 0.65%)	2.03s (± 0.63%)	+0.01s (+ 0.30%)	2.01s	2.07s
Bind Time	0.82s (± 1.37%)	0.82s (± 0.60%)	-0.00s (- 0.37%)	0.81s	0.83s
Check Time	4.75s (± 0.74%)	4.76s (± 0.33%)	+0.01s (+ 0.17%)	4.73s	4.81s
Emit Time	5.21s (± 0.66%)	5.18s (± 1.03%)	-0.03s (- 0.52%)	5.11s	5.38s
Total Time	12.80s (± 0.48%)	12.79s (± 0.54%)	-0.02s (- 0.12%)	12.70s	13.04s
Monaco - node (v10.16.3, x64)
Memory used	339,114k (± 0.02%)	339,024k (± 0.01%)	-90k (- 0.03%)	338,924k	339,106k
Parse Time	1.59s (± 0.93%)	1.59s (± 0.80%)	-0.01s (- 0.31%)	1.55s	1.61s
Bind Time	0.72s (± 0.62%)	0.71s (± 0.48%)	-0.01s (- 0.70%)	0.71s	0.72s
Check Time	4.92s (± 0.62%)	4.93s (± 0.51%)	+0.00s (+ 0.10%)	4.87s	4.98s
Emit Time	2.76s (± 0.64%)	2.76s (± 0.54%)	+0.01s (+ 0.22%)	2.73s	2.81s
Total Time	9.99s (± 0.56%)	9.99s (± 0.42%)	-0.00s (- 0.01%)	9.90s	10.11s
TFS - node (v10.16.3, x64)
Memory used	302,042k (± 0.04%)	301,956k (± 0.01%)	-86k (- 0.03%)	301,843k	302,049k
Parse Time	1.22s (± 0.36%)	1.22s (± 0.76%)	-0.00s (- 0.00%)	1.20s	1.24s
Bind Time	0.67s (± 1.41%)	0.67s (± 1.50%)	-0.01s (- 1.19%)	0.64s	0.68s
Check Time	4.44s (± 0.64%)	4.42s (± 0.51%)	-0.02s (- 0.43%)	4.36s	4.45s
Emit Time	2.92s (± 0.98%)	2.90s (± 0.92%)	-0.02s (- 0.51%)	2.83s	2.95s
Total Time	9.25s (± 0.56%)	9.21s (± 0.47%)	-0.04s (- 0.49%)	9.07s	9.29s
material-ui - node (v10.16.3, x64)
Memory used	458,672k (± 0.01%)	458,059k (± 0.01%)	-613k (- 0.13%)	457,941k	458,182k
Parse Time	2.06s (± 0.24%)	2.05s (± 0.70%)	-0.00s (- 0.19%)	2.03s	2.10s
Bind Time	0.65s (± 1.45%)	0.65s (± 1.12%)	-0.00s (- 0.31%)	0.63s	0.67s
Check Time	12.96s (± 0.84%)	13.14s (± 0.68%)	+0.19s (+ 1.44%)	12.94s	13.32s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	15.67s (± 0.73%)	15.85s (± 0.58%)	+0.18s (+ 1.16%)	15.63s	16.04s
Angular - node (v12.1.0, x64)
Memory used	320,845k (± 0.02%)	320,464k (± 0.02%)	-381k (- 0.12%)	320,334k	320,602k
Parse Time	2.00s (± 0.65%)	2.01s (± 0.52%)	+0.00s (+ 0.20%)	1.99s	2.04s
Bind Time	0.80s (± 0.59%)	0.80s (± 0.59%)	0.00s ( 0.00%)	0.79s	0.81s
Check Time	4.67s (± 0.48%)	4.66s (± 0.57%)	-0.01s (- 0.24%)	4.60s	4.73s
Emit Time	5.38s (± 0.87%)	5.38s (± 0.46%)	-0.01s (- 0.19%)	5.33s	5.43s
Total Time	12.86s (± 0.49%)	12.85s (± 0.35%)	-0.01s (- 0.10%)	12.75s	12.94s
Monaco - node (v12.1.0, x64)
Memory used	321,561k (± 0.02%)	321,542k (± 0.03%)	-19k (- 0.01%)	321,337k	321,756k
Parse Time	1.56s (± 0.91%)	1.56s (± 0.75%)	+0.01s (+ 0.39%)	1.53s	1.59s
Bind Time	0.69s (± 0.69%)	0.69s (± 0.58%)	-0.00s (- 0.58%)	0.68s	0.70s
Check Time	4.71s (± 0.33%)	4.71s (± 0.43%)	+0.00s (+ 0.08%)	4.68s	4.76s
Emit Time	2.82s (± 0.86%)	2.81s (± 0.99%)	-0.01s (- 0.35%)	2.76s	2.88s
Total Time	9.78s (± 0.45%)	9.77s (± 0.49%)	-0.01s (- 0.09%)	9.69s	9.90s
TFS - node (v12.1.0, x64)
Memory used	286,566k (± 0.03%)	286,585k (± 0.02%)	+19k (+ 0.01%)	286,469k	286,686k
Parse Time	1.24s (± 0.80%)	1.24s (± 0.50%)	+0.00s (+ 0.08%)	1.23s	1.26s
Bind Time	0.64s (± 0.53%)	0.64s (± 0.76%)	+0.00s (+ 0.16%)	0.63s	0.65s
Check Time	4.32s (± 0.47%)	4.32s (± 0.25%)	-0.00s (- 0.07%)	4.29s	4.34s
Emit Time	2.91s (± 0.38%)	2.95s (± 0.69%)	+0.04s (+ 1.37%)	2.92s	3.00s
Total Time	9.12s (± 0.32%)	9.16s (± 0.32%)	+0.04s (+ 0.48%)	9.10s	9.22s
material-ui - node (v12.1.0, x64)
Memory used	437,017k (± 0.06%)	436,740k (± 0.01%)	-277k (- 0.06%)	436,598k	436,876k
Parse Time	2.05s (± 0.49%)	2.04s (± 0.55%)	-0.01s (- 0.39%)	2.01s	2.06s
Bind Time	0.63s (± 0.75%)	0.63s (± 1.06%)	-0.00s (- 0.00%)	0.62s	0.65s
Check Time	11.70s (± 1.00%)	11.80s (± 0.67%)	+0.10s (+ 0.85%)	11.68s	12.03s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	14.38s (± 0.78%)	14.47s (± 0.56%)	+0.09s (+ 0.62%)	14.34s	14.69s
Angular - node (v8.9.0, x64)
Memory used	340,158k (± 0.01%)	339,882k (± 0.01%)	-276k (- 0.08%)	339,807k	339,964k
Parse Time	2.56s (± 0.76%)	2.53s (± 0.45%)	-0.03s (- 1.06%)	2.51s	2.56s
Bind Time	0.87s (± 1.01%)	0.85s (± 0.76%)	-0.02s (- 2.53%)	0.84s	0.86s
Check Time	5.40s (± 0.74%)	5.40s (± 0.58%)	-0.00s (- 0.07%)	5.33s	5.45s
Emit Time	6.01s (± 1.31%)	5.93s (± 1.84%)	-0.09s (- 1.46%)	5.64s	6.20s
Total Time	14.84s (± 0.83%)	14.71s (± 0.84%)	-0.13s (- 0.90%)	14.35s	14.94s
Monaco - node (v8.9.0, x64)
Memory used	340,410k (± 0.01%)	340,411k (± 0.02%)	+2k (+ 0.00%)	340,245k	340,505k
Parse Time	1.89s (± 0.64%)	1.88s (± 0.46%)	-0.02s (- 0.84%)	1.86s	1.89s
Bind Time	0.89s (± 0.53%)	0.89s (± 0.69%)	-0.00s (- 0.45%)	0.88s	0.90s
Check Time	5.48s (± 0.66%)	5.44s (± 0.61%)	-0.04s (- 0.66%)	5.35s	5.51s
Emit Time	3.24s (± 1.10%)	3.23s (± 1.22%)	-0.01s (- 0.19%)	3.16s	3.33s
Total Time	11.50s (± 0.32%)	11.44s (± 0.52%)	-0.06s (- 0.54%)	11.28s	11.55s
TFS - node (v8.9.0, x64)
Memory used	303,778k (± 0.01%)	303,834k (± 0.02%)	+56k (+ 0.02%)	303,750k	303,984k
Parse Time	1.55s (± 0.31%)	1.55s (± 0.50%)	+0.00s (+ 0.13%)	1.53s	1.56s
Bind Time	0.68s (± 0.44%)	0.68s (± 0.66%)	0.00s ( 0.00%)	0.67s	0.69s
Check Time	5.15s (± 1.34%)	5.14s (± 1.29%)	-0.01s (- 0.21%)	4.96s	5.28s
Emit Time	2.98s (± 2.53%)	2.98s (± 2.88%)	-0.00s (- 0.13%)	2.85s	3.21s
Total Time	10.36s (± 0.57%)	10.35s (± 0.45%)	-0.01s (- 0.12%)	10.21s	10.46s
material-ui - node (v8.9.0, x64)
Memory used	462,949k (± 0.01%)	462,532k (± 0.01%)	-417k (- 0.09%)	462,430k	462,652k
Parse Time	2.41s (± 0.60%)	2.41s (± 0.34%)	+0.01s (+ 0.29%)	2.40s	2.43s
Bind Time	0.78s (± 1.11%)	0.78s (± 1.04%)	+0.00s (+ 0.26%)	0.76s	0.80s
Check Time	17.30s (± 1.28%)	17.56s (± 0.77%)	+0.26s (+ 1.49%)	17.26s	17.85s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	20.48s (± 1.10%)	20.75s (± 0.68%)	+0.26s (+ 1.29%)	20.45s	21.03s
Angular - node (v8.9.0, x86)
Memory used	195,227k (± 0.02%)	195,084k (± 0.03%)	-143k (- 0.07%)	194,942k	195,207k
Parse Time	2.48s (± 0.99%)	2.46s (± 0.50%)	-0.01s (- 0.61%)	2.43s	2.48s
Bind Time	0.99s (± 0.95%)	0.99s (± 1.17%)	+0.00s (+ 0.51%)	0.97s	1.01s
Check Time	4.88s (± 0.62%)	4.88s (± 0.52%)	+0.00s (+ 0.02%)	4.82s	4.93s
Emit Time	5.94s (± 0.62%)	5.96s (± 0.88%)	+0.01s (+ 0.20%)	5.89s	6.11s
Total Time	14.29s (± 0.24%)	14.29s (± 0.42%)	+0.00s (+ 0.03%)	14.12s	14.42s
Monaco - node (v8.9.0, x86)
Memory used	193,520k (± 0.02%)	193,515k (± 0.01%)	-6k (- 0.00%)	193,432k	193,567k
Parse Time	1.92s (± 0.99%)	1.92s (± 0.70%)	-0.01s (- 0.31%)	1.89s	1.95s
Bind Time	0.70s (± 1.16%)	0.70s (± 0.68%)	-0.00s (- 0.00%)	0.69s	0.71s
Check Time	5.52s (± 1.01%)	5.55s (± 1.19%)	+0.02s (+ 0.45%)	5.32s	5.65s
Emit Time	2.72s (± 2.76%)	2.74s (± 3.22%)	+0.02s (+ 0.59%)	2.65s	3.08s
Total Time	10.86s (± 0.51%)	10.90s (± 0.54%)	+0.03s (+ 0.30%)	10.82s	11.06s
TFS - node (v8.9.0, x86)
Memory used	173,728k (± 0.03%)	173,766k (± 0.02%)	+38k (+ 0.02%)	173,658k	173,847k
Parse Time	1.59s (± 1.01%)	1.60s (± 0.99%)	+0.01s (+ 0.44%)	1.57s	1.64s
Bind Time	0.64s (± 0.35%)	0.64s (± 0.90%)	+0.00s (+ 0.31%)	0.63s	0.66s
Check Time	4.67s (± 0.55%)	4.69s (± 0.56%)	+0.01s (+ 0.21%)	4.63s	4.75s
Emit Time	2.80s (± 0.94%)	2.81s (± 1.90%)	+0.01s (+ 0.46%)	2.68s	2.90s
Total Time	9.71s (± 0.61%)	9.74s (± 0.44%)	+0.03s (+ 0.29%)	9.60s	9.82s
material-ui - node (v8.9.0, x86)
Memory used	262,200k (± 0.01%)	262,213k (± 0.02%)	+13k (+ 0.01%)	262,092k	262,276k
Parse Time	2.46s (± 0.88%)	2.46s (± 0.55%)	-0.00s (- 0.16%)	2.43s	2.49s
Bind Time	0.67s (± 1.32%)	0.68s (± 1.12%)	+0.01s (+ 1.35%)	0.66s	0.69s
Check Time	15.83s (± 0.83%)	15.91s (± 0.60%)	+0.09s (+ 0.55%)	15.71s	16.11s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	18.96s (± 0.74%)	19.05s (± 0.53%)	+0.09s (+ 0.48%)	18.83s	19.24s

System

Machine Name	ts-ci-ubuntu
Platform	linux 4.4.0-166-generic
Architecture	x64
Available Memory	16 GB
Available Memory	1 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v10.16.3, x64)
• node (v12.1.0, x64)
• node (v8.9.0, x64)
• node (v8.9.0, x86)

Scenarios

• Angular - node (v10.16.3, x64)
• Angular - node (v12.1.0, x64)
• Angular - node (v8.9.0, x64)
• Angular - node (v8.9.0, x86)
• Monaco - node (v10.16.3, x64)
• Monaco - node (v12.1.0, x64)
• Monaco - node (v8.9.0, x64)
• Monaco - node (v8.9.0, x86)
• TFS - node (v10.16.3, x64)
• TFS - node (v12.1.0, x64)
• TFS - node (v8.9.0, x64)
• TFS - node (v8.9.0, x86)
• material-ui - node (v10.16.3, x64)
• material-ui - node (v12.1.0, x64)
• material-ui - node (v8.9.0, x64)
• material-ui - node (v8.9.0, x86)

Benchmark	Name	Iterations
Current	39232	10
Baseline	master	10

[weswigham]

Perf looks OK - there's potentially a ~1% difference in material-ui check time (varies with node version) and no changes anywhere else, so definitely nothing catastrophic. So pref-wise this approach should be fine. User and RWC look fine - just some elaboration changes. DT has some new errors, though. In raphael it looks like a new structural breakdown is finding a strict null checks error in an assignment (which is probably more correct, albeit a break). There's a similar new error in knockout.mapping, which also likely indicates an undetected bug in the types. meteor (and angular-meteor) has a new Type instantiation is excessively deep and possibly infinite. error in its tests that's concerning. It's not much, but it does need looking into (preliminary check seems to indicate it's related to conditional type variance).

[nscarcella]

Tried compiling the project against this branch, but we are still getting this error:

/home/nicolas/Development/Programs/Typescript/wollok-ts/node_modules/typescript/lib/typescript.js:43927
        function getIsDeferredContext(location, lastLocation) {
                                     ^
RangeError: Maximum call stack size exceeded
    at getIsDeferredContext (/home/nicolas/Development/Programs/Typescript/wollok-ts/node_modules/typescript/lib/typescript.js:43927:38)
    at resolveNameHelper (/home/nicolas/Development/Programs/Typescript/wollok-ts/node_modules/typescript/lib/typescript.js:43585:66)
    at resolveName (/home/nicolas/Development/Programs/Typescript/wollok-ts/node_modules/typescript/lib/typescript.js:43521:20)
    at resolveEntityName (/home/nicolas/Development/Programs/Typescript/wollok-ts/node_modules/typescript/lib/typescript.js:44744:42)
    at resolveTypeReferenceName (/home/nicolas/Development/Programs/Typescript/wollok-ts/node_modules/typescript/lib/typescript.js:52868:20)
    at getTypeFromTypeReference (/home/nicolas/Development/Programs/Typescript/wollok-ts/node_modules/typescript/lib/typescript.js:53051:30)
    at getTypeFromTypeNodeWorker (/home/nicolas/Development/Programs/Typescript/wollok-ts/node_modules/typescript/lib/typescript.js:54919:28)
    at getTypeFromTypeNode (/home/nicolas/Development/Programs/Typescript/wollok-ts/node_modules/typescript/lib/typescript.js:54881:49)
    at tryGetTypeFromEffectiveTypeNode (/home/nicolas/Development/Programs/Typescript/wollok-ts/node_modules/typescript/lib/typescript.js:49450:24)
    at getTypeForVariableLikeDeclaration (/home/nicolas/Development/Programs/Typescript/wollok-ts/node_modules/typescript/lib/typescript.js:48972:32)

It's has a different stack trace than the one we got on #39059, but seems related.

[sandersn]

Unfortunately, we never finished reviewing this PR. It is pretty old now, so I'm going to close it to reduce the number of open PRs.