Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add refactor convertToOptionalChainExpression #39135

Merged
merged 49 commits into from
Jul 14, 2020
Merged

Add refactor convertToOptionalChainExpression #39135

merged 49 commits into from
Jul 14, 2020

Commits on Jun 18, 2020

  1. add convertOptionalChain

    Jesse Trinity committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    77a49c3 View commit details
    Browse the repository at this point in the history

  2. cover more cases

    Jesse Trinity committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    9cf07cf View commit details
    Browse the repository at this point in the history

  3. expose containsMatchingReference

    Jesse Trinity committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    80bf5d1 View commit details
    Browse the repository at this point in the history

  4. clean up performing edits

    Jesse Trinity committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    4e64236 View commit details
    Browse the repository at this point in the history

  5. bound start position

    Jesse Trinity committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    9a59e13 View commit details
    Browse the repository at this point in the history

  6. add tests

    Jesse Trinity committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    6c1bccf View commit details
    Browse the repository at this point in the history

  7. refactor and handle edge cases

    Jesse Trinity committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    2a355e4 View commit details
    Browse the repository at this point in the history

  8. update tests

    Jesse Trinity committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    3dac9c6 View commit details
    Browse the repository at this point in the history

  9. consider explicit requests for empty spans

    Jesse Trinity committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    b403037 View commit details
    Browse the repository at this point in the history

  10. update fourslash to use trigger reason

    Jesse Trinity committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    1ae5500 View commit details
    Browse the repository at this point in the history

  11. add tests cases for trigger reason

    Jesse Trinity committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    bf28673 View commit details
    Browse the repository at this point in the history

  12. fix errors

    Jesse Trinity committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    fa3f9c8 View commit details
    Browse the repository at this point in the history

  13. remove type assertion

    Jesse Trinity committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    8794154 View commit details
    Browse the repository at this point in the history

  14. fix non ampersand chains

    Jesse Trinity committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    3d8fed1 View commit details
    Browse the repository at this point in the history

  15. clean up some logic

    Jesse Trinity committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    b5c833c View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2020

  1. add ternary case

    Jesse Trinity committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    796b2bf View commit details
    Browse the repository at this point in the history

  2. add diagnostic message

    Jesse Trinity committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    37004b7 View commit details
    Browse the repository at this point in the history

  3. resolve merge conflict

    Jesse Trinity committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    3584bae View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. Merge remote-tracking branch 'upstream/master' into refactorOptionalC… 

    …hain
    Jesse Trinity committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    1b2e86b View commit details
    Browse the repository at this point in the history

  2. add nullish check for ternary expressions

    Jesse Trinity committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    afb0e44 View commit details
    Browse the repository at this point in the history

  3. Update src/services/refactors/convertToOptionalChainExpression.ts 

    Co-authored-by: Nathan Shively-Sanders <[email protected]>
    @jessetrinity @sandersn
    jessetrinity and sandersn authored Jun 22, 2020
    Configuration menu
    Copy the full SHA
    65ca81e View commit details
    Browse the repository at this point in the history

  4. Update src/services/refactors/convertToOptionalChainExpression.ts 

    Co-authored-by: Nathan Shively-Sanders <[email protected]>
    @jessetrinity @sandersn
    jessetrinity and sandersn authored Jun 22, 2020
    Configuration menu
    Copy the full SHA
    d9c34ff View commit details
    Browse the repository at this point in the history

  5. Update tests/cases/fourslash/refactorConvertToOptionalChainExpression… 

    …ForTriggerReason3.ts

Co-authored-by: Nathan Shively-Sanders <[email protected]>
    @jessetrinity @sandersn
    jessetrinity and sandersn authored Jun 22, 2020
    Configuration menu
    Copy the full SHA
    c2b9924 View commit details
    Browse the repository at this point in the history

  6. Update tests/cases/fourslash/refactorConvertToOptionalChainExpression… 

    …ForTriggerReason1.ts

Co-authored-by: Nathan Shively-Sanders <[email protected]>
    @jessetrinity @sandersn
    jessetrinity and sandersn authored Jun 22, 2020
    Configuration menu
    Copy the full SHA
    1d51dab View commit details
    Browse the repository at this point in the history

  7. reformat and remove unused checks

    Jesse Trinity committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    adbd586 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. allow any for ternary refactor

    Jesse Trinity committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    fb6b831 View commit details
    Browse the repository at this point in the history

  2. add tests

    Jesse Trinity committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    8184ecf View commit details
    Browse the repository at this point in the history

  3. add tests

    Jesse Trinity committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    5ac29a0 View commit details
    Browse the repository at this point in the history

  4. check return and variable statements

    Jesse Trinity committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    a0708be View commit details
    Browse the repository at this point in the history

  5. use isMatchingReference instead of containsMatchingReference

    Jesse Trinity committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    6810cea View commit details
    Browse the repository at this point in the history

  6. allow partial selections

    Jesse Trinity committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    5634a4c View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2020

  1. fine tune selection ranges

    Jesse Trinity committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    e6e54cb View commit details
    Browse the repository at this point in the history

  2. recurse for call expressions

    Jesse Trinity committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    77f47e7 View commit details
    Browse the repository at this point in the history

  3. fix spellings

    Jesse Trinity committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    1ba5fd0 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. add recursive cases

    Jesse Trinity committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    6095e95 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2020

  1. remove isOrContainsMatchingReference

    Jesse Trinity committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    89c8c9d View commit details
    Browse the repository at this point in the history

  2. cleanup

    Jesse Trinity committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    b20cd95 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2020

  1. more refactoring

    Jesse Trinity committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    15176b2 View commit details
    Browse the repository at this point in the history

  2. cleanup

    Jesse Trinity committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    2de5e28 View commit details
    Browse the repository at this point in the history

  3. rename tests

    Jesse Trinity committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    4126a46 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2020

  1. address PR comments

    Jesse Trinity committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    8f65c02 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into refactorOptionalC… 

    …hain
    Jesse Trinity committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    d4f6f52 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2020

  1. check match syntactically

    Jesse Trinity committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    8aed315 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. handle another call expression case

    Jesse Trinity committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    602075f View commit details
    Browse the repository at this point in the history

  2. some renames

    Jesse Trinity committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    a4cc060 View commit details
    Browse the repository at this point in the history

  3. inline some checks

    Jesse Trinity committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    e89ae08 View commit details
    Browse the repository at this point in the history

  4. add test

    Jesse Trinity committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    2cdb5e1 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2020

  1. address comments

    Jesse Trinity committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    fd64b14 View commit details
    Browse the repository at this point in the history

  2. add refactorNotAvailableReason

    Jesse Trinity committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    01854bb View commit details
    Browse the repository at this point in the history