Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error #38525

Merged
merged 1 commit into from
May 13, 2020
Merged

Build error #38525

merged 1 commit into from
May 13, 2020

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented May 13, 2020

Fixes Nothing but
#38518
#38522
#38523
#38526

@typescript-bot
Copy link
Collaborator

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

@orta
Copy link
Contributor

orta commented May 13, 2020

Thanks @Kingwl - this looks good to me

@orta orta merged commit 9725d62 into microsoft:master May 13, 2020
@Kingwl Kingwl deleted the build_error branch May 13, 2020 13:21
cangSDARM added a commit to cangSDARM/TypeScript that referenced this pull request May 14, 2020
* upstream/master:
  Perform intersection reduction before and after getApparentType (microsoft#38565)
  fix(33836): allow readonly modifier for a field with only get accessor (microsoft#36543)
  Fix build type error (microsoft#38525)
@weswigham
Copy link
Member

@typescript-bot cherry-pick this into release-3.9

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 14, 2020

Heya @weswigham, I've started to run the task to cherry-pick this into release-3.9 on this PR at 19624fa. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @weswigham, I've opened #38582 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request May 14, 2020
Component commits:
19624fa Fix build type error
weswigham pushed a commit that referenced this pull request May 14, 2020
Component commits:
19624fa Fix build type error

Co-authored-by: kingwl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants