Fix renaming an ExportSpecifier name when propertyName is present #36790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
approved these changes
Feb 13, 2020
|
@typescript-bot cherry-pick this to release-3.8, or are you still on vacation? |
|
Heya @andrewbranch, I couldn't find the branch 'release-3.8,' on Microsoft/TypeScript. You may need to make it and try again. |
andrewbranch
added a commit
to andrewbranch/TypeScript
that referenced
this pull request
Feb 14, 2020
…crosoft#36790) * Fix renaming exportSpecifier name when propertyName is present * Add baseline test for name without propertyName too
andrewbranch
added a commit
that referenced
this pull request
Feb 28, 2020
* Fix renaming an ExportSpecifier name when propertyName is present (#36790) * Fix renaming exportSpecifier name when propertyName is present * Add baseline test for name without propertyName too * Set correct pos for NamespaceExport (#36794) * Set correct pos for NamespaceExport * Update tests * Cherry-pick PR #37064 into release-3.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36695, which I suspect was a regression from #36490