Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .filter(Boolean) #36759

Closed
wants to merge 2 commits into from
Closed

Conversation

samdenty
Copy link

Add overload for Array.filter, removing falsy values when Boolean is passed.

@sandersn
Copy link
Member

Problems with Array methods are being discussed at #36554, after which the proposed solutions will need extensive discussion and testing. That means the final fixes won't necessarily look like this PR.

@RyanCavanaugh
Copy link
Member

Please track upstream at #36554. We would need this to be rolled in with all the other changes, and we also need an approved issue for all PRs. I'm particularly very concerned about making something as sensitive as filter be overloaded instead of unoverloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants