Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(36249): Declare property quick fix should add private properties (or be configurable) #36632

Merged
merged 2 commits into from
Mar 13, 2020
Merged

feat(36249): Declare property quick fix should add private properties (or be configurable) #36632

merged 2 commits into from
Mar 13, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #36249

@a-tarasyuk a-tarasyuk changed the title feat(36249): add quick-fix action to declare a property as private wh… feat(36249): Declare property quick fix should add private properties (or be configurable) Feb 5, 2020
@a-tarasyuk a-tarasyuk marked this pull request as ready for review February 6, 2020 09:26
@sandersn sandersn added the For Backlog Bug PRs that fix a backlog bug label Feb 14, 2020
@sandersn sandersn added For Uncommitted Bug PR for untriaged, rejected, closed or missing bug and removed For Backlog Bug PRs that fix a backlog bug labels Mar 12, 2020
@sandersn sandersn requested a review from amcasey March 12, 2020 17:38
amcasey
amcasey approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick about the text. Thanks!

src/compiler/diagnosticMessages.json Outdated Show resolved Hide resolved
@amcasey amcasey merged commit b41eb1b into microsoft:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcasey amcasey amcasey approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees

@amcasey amcasey

Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Declare property quick fix should add private properties (or be configurable)
3 participants
@a-tarasyuk @amcasey @sandersn