Backward-compatible accessor emit #33880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessors are now only emitted in d.ts when useDefineForClassFields is set. Otherwise, properties that originated as accessors are prefixed with a JSDoc tag: `/**@Accessor*/` The checker now understands `/**@Accessor*/` tags for the purpose of error reporting; if --useDefineForClassFields is provided, an ambient base property with `/**@Accessor*/` will be treated as an accessor, not as a property.
|
@sandersn would this approach hold for people using the "removeComments" field of compiler options? |
|
It should, but I have not tested it. I decided not to take this PR, however. Instead I recommend that people who need 3.5-compatible d.ts files use a tool like https://github.com/sandersn/downlevel-dts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessors are now only emitted in d.ts when useDefineForClassFields is set. Otherwise, properties that originated as accessors are prefixed with a JSDoc tag:
/**@accessor*/The checker now understands
/**@accessor*/tags for the purpose of error reporting; if --useDefineForClassFields is provided, an ambient base property with/**@accessor*/will be treated as an accessor, not as a property.Reverts the declarations.ts part of #33509.
Eventually the new d.ts emit should become the default, once there are enough versions of Typescript that can parse the new syntax. At that point this code will once again go away.