Better typings for Array.map() #33832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jablko
force-pushed
the
patch-17
branch
2 times, most recently
from
b6e11d6 to
59de40a
Compare
jablko
force-pushed
the
patch-17
branch
2 times, most recently
from
f25a970 to
6e6d2e5
Compare
jablko
force-pushed
the
patch-17
branch
5 times, most recently
from
7290d04 to
0d849d4
Compare
jablko
force-pushed
the
patch-17
branch
3 times, most recently
from
fc4b235 to
ba11b95
Compare
jablko
force-pushed
the
patch-17
branch
2 times, most recently
from
eec46f9 to
952463a
Compare
jablko
force-pushed
the
patch-17
branch
6 times, most recently
from
87c8ab5 to
13feab6
Compare
|
This PR hasn't seen any activity for quite a while, so I'm going to close it to keep the number of open PRs manageable. I think we should finish the discussion at #36554 before making changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
> node built/local/tsc.js --diagnostics --p src/compiler/tsconfig.json Files: 124 Lines: 144298 Nodes: 685484 Identifiers: 274646 Symbols: 148671 Types: 51651 Memory used: 560305K I/O read: 0.03s I/O write: 0.06s Parse time: 2.02s Bind time: 2.48s Check time: 11.52s Emit time: 7.49s Total time: 23.50sAfter
> node built/local/tsc.js --diagnostics --p src/compiler/tsconfig.json Files: 124 Lines: 144298 Nodes: 685510 Identifiers: 274652 Symbols: 151814 Types: 52094 Memory used: 562092K I/O read: 0.03s I/O write: 0.06s Parse time: 2.02s Bind time: 2.43s Check time: 11.96s Emit time: 7.39s Total time: 23.81sAbout 3,000 more symbols and 1% more total time.
Depends on #33885
Fixes #29841