Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore union-like behavior for inference to conditional types #32208

Merged
merged 2 commits into from
Jul 2, 2019

Conversation

ahejlsberg
Copy link
Member

Fixes #31766.

Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should check that that node8 test is passing, too - I restarted it because the failure seemed unrelated (maybe due to a nested dependency) hopefully it's ok on rerun.

@weswigham
Copy link
Member

cc @rbuckton re: the node 8 failure on this PR. That failure looks like it's in an untranspiled optional catch clause in a library you happen to maintain: https://github.com/esfx/esfx/blob/master/internal/deprecate/src/index.ts

@rbuckton
Copy link
Member

rbuckton commented Jul 2, 2019

Should be fixed now. I restarted the node 8 build and it passed successfully.

@ahejlsberg ahejlsberg merged commit 345777e into master Jul 2, 2019
@ahejlsberg ahejlsberg deleted the fix31766 branch July 2, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic type inference prefers conditional types
3 participants