Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to allow access to UMD globals from modules #30776

Merged
merged 8 commits into from
Apr 19, 2019
Merged

Add flag to allow access to UMD globals from modules #30776

merged 8 commits into from
Apr 19, 2019

Commits on Apr 8, 2019

  1. Add allowUmdGlobalAccess flag

    @andrewbranch
    andrewbranch committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    2ee93bf View commit details
    Browse the repository at this point in the history

  2. Add test

    @andrewbranch
    andrewbranch committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    6d1d680 View commit details
    Browse the repository at this point in the history

  3. Don’t emit diagnostic accessing UMD globals from modules when flag is… 

    … set
    @andrewbranch
    andrewbranch committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    11e4516 View commit details
    Browse the repository at this point in the history

  4. Add baselines for UMD global access

    @andrewbranch
    andrewbranch committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    57b9e38 View commit details
    Browse the repository at this point in the history

  5. Add period to compiler flag description to match others

    @andrewbranch
    andrewbranch committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    28b21df View commit details
    Browse the repository at this point in the history

  6. Update baselines with new flag

    @andrewbranch
    andrewbranch committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    6c06507 View commit details
    Browse the repository at this point in the history

  7. Add affectsSemanticDiagnostics to flag (and move to right spot)

    @andrewbranch
    andrewbranch committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    98cd89f View commit details
    Browse the repository at this point in the history

  8. Use suggestion instead of ignoring UMD global access

    @andrewbranch
    andrewbranch committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    786753d View commit details
    Browse the repository at this point in the history