Make removeSubtypes resilient to reentry #3071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3572,7 +3572,18 @@ module ts { | |||
| return false; | |||
| } | |||
|
|
|||
| // Since removeSubtypes checks the subtype relation, and the subtype relation on a union | |||
| // may attempt to reduce a union, it is possible that removeSubtypes could be called | |||
| // recursively on the same set of types. | |||
There was a problem hiding this comment.
For a future reader, this comment might leave them thinking "and...?"
Explain further that the stack is used to detect when subtype reduction is currentlytaking place for a given union type.
There was a problem hiding this comment.
// Since removeSubtypes checks the subtype relation, and the subtype relation on a union
// may attempt to reduce a union, it is possible that removeSubtypes could be called
// recursively on the same set of types. The removeSubtypesStack is used to track which
// sets of types are currently undergoing subtype reduction.
…into removeSubtypesRecursion
JsonFreeman
force-pushed
the
removeSubtypesRecursion
branch
from
2425310
to
7a92282
Compare
|
Since we have a tendency to add related tests with similar names, in the future suffix test names with 👍 |
JsonFreeman
added a commit
that referenced
this pull request
May 7, 2015
Make removeSubtypes resilient to reentry
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2997