Handle huge unions better in createUnionOrIntersectionProperty #30411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
requested changes
Mar 14, 2019
|
There's not really a noticeable difference in check time one way or the other in the
|
|
@typescript-bot perf test 🕙 |
|
Heya @weswigham, I've started to run the perf test suite on this PR at 44e0aa0. You can monitor the build here. It should now contribute to this PR's status checks. |
|
@sandersn There's no perf diff between this branch and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29834 - or at least makes it more tolerable.
Timeline before this fix, roughly 7 seconds until first results for a quickinfo relying on the 1MB data object:
Timeline after this fix for the same info:
Down to 2s. (Specifically, time in
createUnionOrIntersectionPropertywas cut from 5s down to 340ms)That's a pretty big improvement for just fixing property creation so it's not O(n^2) with property count. 😄
There's not really a test associated with this change because, well, perf...