unify file extension resolution logic #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const extensitionsToRemove = [".d.ts", ".ts", ".js"]; |
| @@ -1974,7 +1974,7 @@ | |||
| "category": "Error", | |||
| "code": 6053 | |||
| }, | |||
| "File '{0}' must have extension '.ts' or '.d.ts'.": { | |||
| "File '{0}' has unsupported extension. The only supported extensions are {1}.": { | |||
There was a problem hiding this comment.
an unsupported extension
There was a problem hiding this comment.
did that,, then felt too hard to read; this is still grammatically correct and gives the same meaning.
There was a problem hiding this comment.
OR, keep it the same and make it
"File '{0}' has unsupported extension '{1}'. The only supported extensions are {2}."
There was a problem hiding this comment.
I would rather switch back to the old message then, at least it had the "or".. :D
|
Ping 🔔 @CyrusNajmabadi , @DanielRosenwasser and @vladima any more comments? |
|
👍 LGTM |
mhegazy
added a commit
that referenced
this pull request
May 7, 2015
unify file extension resolution logic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We explicitly list ".ts" and ".d.ts" files every time we resolve files or modules. This change puts the two extensions in a list of supported extensions, and uses it everywhere. This allows for easy addition to supported extensions, e.g. the work @CyrusNajmabadi and @fdecampredon are doing.