Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better error message for incompatible constructor signature #28113

Closed
wants to merge 1 commit into from
Closed

Provide better error message for incompatible constructor signature #28113

wants to merge 1 commit into from

Conversation

Roshanjossey
Copy link

Fixes #21253

  • There is an associated issue that is labeled
    'Bug' or 'help wanted' or is in the Community milestone
  • Code is up-to-date with the master branch
  • You've successfully run jake runtests locally
  • You've signed the CLA
  • There are new or updated unit tests validating the change

Sorry, something went wrong.

@msftclas
Copy link

msftclas commented Oct 24, 2018

CLA assistant check
All CLA requirements met.

@@ -4687,5 +4687,9 @@
"Generate types for all packages without types": {
"category": "Message",
"code": 95068
},
"Types of construct signature is incompatible.": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"is" should be "are"?

Suggested change
"Types of construct signature is incompatible.": {
"Types of construct signature are incompatible.": {

@yume-chan
Copy link
Contributor

Any updates on this?

@RyanCavanaugh
Copy link
Member

Closing due to inactivity. Feel free to open a fresh PR if you'd like to continue work on the issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants