Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow GLBoolean as param in pixelstorei #27933

Closed
wants to merge 1 commit into from
Closed

Allow GLBoolean as param in pixelstorei #27933

wants to merge 1 commit into from

Conversation

AVGP
Copy link

@AVGP AVGP commented Oct 17, 2018 •
edited
Loading

Fixes #27542

@j-oliveras
Copy link
Contributor

Files from lib folder are generated from src/lib folder. Some files from src/lib are generated from TSJS-lib-generator repository.

Read Contributing lib.d.ts fixes for more info.

@AVGP
Copy link
Author

AVGP commented Oct 17, 2018

Fair enough, that's why I made the corresponding change in TSJS as well - see microsoft/TypeScript-DOM-lib-generator#583

Unless I'm missing something, this PR is still needed to get the change into TypeScript, no?

@fatcerberus
Copy link

What's really bizarre is that this exact issue appears to have been fixed about 2 years ago:
microsoft/TypeScript-DOM-lib-generator#178

But it's clearly broken now. Was the change accidentally reverted?

@RyanCavanaugh
Copy link
Member

TSJS-lib-generator is the correct place for this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AVGP @j-oliveras @fatcerberus @RyanCavanaugh