Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have scanJsDocToken scan keywords #27162

Merged
3 commits merged into from
Oct 8, 2018
Merged

Have scanJsDocToken scan keywords #27162

3 commits merged into from
Oct 8, 2018

Conversation

ghost
Copy link

@ghost ghost commented Sep 17, 2018

Fixes #27159

Reverts #26915 and replaces it with an alternative fix that avoids calling scan() which reports errors on #. Baseline changes are reverting those in #26915.

@ghost ghost requested a review from sandersn September 17, 2018 22:25
@RyanCavanaugh RyanCavanaugh added this to the TypeScript 3.2 milestone Sep 17, 2018
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, although you should probably run it on some the user tests to make sure no bizarre new error show up.
(also the API baselines need to be updated.)

@ghost ghost merged commit dd9b8ca into master Oct 8, 2018
@ghost ghost deleted the scanJsDocToken_keyword branch October 8, 2018 21:42
ghost pushed a commit that referenced this pull request Oct 22, 2018
* Have scanJsDocToken scan keywords

* Update API
ghost pushed a commit that referenced this pull request Oct 22, 2018
* Have scanJsDocToken scan keywords

* Update API
ghost pushed a commit that referenced this pull request Oct 24, 2018
* Fix bug: Ensure JSDoc type range is valid

* Have scanJsDocToken scan keywords (#27162)

* Have scanJsDocToken scan keywords

* Update API

* Add 'no-unnecessary-type-assertion' tslint disables
mrcrane pushed a commit to mrcrane/TypeScript that referenced this pull request Jul 26, 2019
…t#28008)

* Fix bug: Ensure JSDoc type range is valid

* Have scanJsDocToken scan keywords (microsoft#27162)

* Have scanJsDocToken scan keywords

* Update API

* Add 'no-unnecessary-type-assertion' tslint disables
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In JS, "Invalid character" error for # right after any JSDoc tag
2 participants