Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lookup regression again and again #26810

Merged

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Aug 31, 2018

Fixes #26808

hope do not fix again and again and again🤷🏻‍♂️

@RyanCavanaugh
Copy link
Member

@Kingwl thank you for your persistence and timely responses on this! Obviously we are starting to get a little worried - #26813 also just came up, though it appears to be fixed by this PR.

I'm going to revert the prior two PRs and ask that you submit a fresh PR with this fix and the prior ones all rolled into one, along with testcases. I'll put the tests in the revert PR, along with an extracted repro from #26813, so that we can more easily review the changes together and make sure the right thing is happening.

Thanks again!

@RyanCavanaugh
Copy link
Member

#26820 is in now, so please rebase

@Kingwl
Copy link
Contributor Author

Kingwl commented Sep 1, 2018

sorry about that😅

@Kingwl
Copy link
Contributor Author

Kingwl commented Sep 3, 2018

updated

@RyanCavanaugh
Copy link
Member

@ahejlsberg this is the cleaned-up PR we discussed last week

@RyanCavanaugh RyanCavanaugh added this to the TypeScript 3.2 milestone Sep 17, 2018
@RyanCavanaugh
Copy link
Member

@Kingwl can you fix the merge conflict? Sorry for the delay

@Kingwl
Copy link
Contributor Author

Kingwl commented Oct 10, 2018

sure, a few moments later

@Kingwl Kingwl force-pushed the fix_lookup_regression_again_and_again branch from 7763347 to 20054d9 Compare October 10, 2018 07:24
@RyanCavanaugh
Copy link
Member

Looks good; let's see what shows up in nightly feedback 😅

@RyanCavanaugh RyanCavanaugh merged commit fc78839 into microsoft:master Oct 10, 2018
@Kingwl Kingwl deleted the fix_lookup_regression_again_and_again branch October 11, 2018 01:01
@Kingwl
Copy link
Contributor Author

Kingwl commented Oct 27, 2018

seems everything is ok 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong referenced symbol in parameter intializer
3 participants