fix lookup regression again #26762
Merged
fix lookup regression again #26762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kingwl thank you for the follow-up! Can you please add a testcase with the repro from the linked issue? |
|
@RyanCavanaugh the baseline change is actually the same as my repro in the linked issue |
|
@ajafff true. I'd still prefer an explicit example - we are much more likely to notice an error file going from 0 to 1 or vice versa than a type baseline changing. |
|
sure, wait a few moment |
sandersn
approved these changes
Aug 30, 2018
|
Thanks for the second fix @Kingwl. |
|
@sandersn |
RyanCavanaugh
added a commit
to RyanCavanaugh/TypeScript
that referenced
this pull request
Aug 31, 2018
This reverts commit 038f665.
RyanCavanaugh
added a commit
to RyanCavanaugh/TypeScript
that referenced
this pull request
Aug 31, 2018
…ration for a clean PR fixing all the issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26731