Still generate signatures in SkipContextSensitive mode just to match on return types #25937
Conversation
src/compiler/checker.ts
Outdated
| if (!getEffectiveReturnTypeNode(node) && hasContextSensitiveReturnExpression(node)) { | ||
| const returnType = getReturnTypeFromBody(node, checkMode); | ||
| const singleReturnSignature = createSignature(undefined, undefined, undefined, emptyArray, returnType, /*resolvedTypePredicate*/ undefined, 0, /*hasRestParameter*/ false, /*hasLiteralTypes*/ false); | ||
| return createAnonymousType(node.symbol, emptySymbols, [singleReturnSignature], emptyArray, undefined, undefined); |
There was a problem hiding this comment.
Is it worth caching this type in some way? Like having an internal () => T generic that I simply instantiate here?
|
@typescript-bot test this |
|
Heya @weswigham, I've started to run the extended test suite on this PR at e061ea1. You can monitor the build here. It should now contribute to this PR's status checks. |
|
@typescript-bot test this now that RWC is clean |
|
Heya @weswigham, I've started to run the extended test suite on this PR at e061ea1. You can monitor the build here. It should now contribute to this PR's status checks. |
|
@typescript-bot test this now that RWC is clean and I've merged master 🤦♂️ |
|
Heya @weswigham, I've started to run the extended test suite on this PR at 8b71962. You can monitor the build here. It should now contribute to this PR's status checks. |
* origin/master: (283 commits) Don't error on destructure of private property with computed property syntax (microsoft#26360) getDefaultExportInfo: Use `getImmediateAliasedSymbol` instead of `getAliasedSymbol` (microsoft#26364) review comments restore old algorithm Dont use baseURL relative absolute paths in declaration emit, use absolute paths in bundle emit (microsoft#26341) Update user baselines (microsoft#26358) Don't store @template constraint in a TypeParameterDeclaration node (microsoft#26283) fixAddMissingMember: Support interface and don't crash on type parameter (microsoft#25995) Don't include class getter in spread type (microsoft#26287) Don't crash on computed property in destructure (microsoft#26334) Check the ambientness of a symbol name before attempting to trim it (microsoft#26312) Still generate signatures in SkipContextSensitive mode just to match on return types (microsoft#25937) fix handling if there is no commonPrefix Actually add sorting of elaboration text to user baselines Ping ryan instead of mohammed for user PRs now handle failed lookups make it work for root directory really, really fix test(?) add test fix commonPrefix handling ...
(during inference).
Fixes #13118
I've kept it minimal - we only dive into the return type if there's a contextual return type whose contextual checking could fix a type parameter before the second, context-sensitive pass. It's worth noting that this has inherited our current slightly flawed definition of a context sensitive function return - namely that only arrow return expressions can be context sensitive (
returnstatements cannot). ThatTODOis probably worth fixing at some point.