Better "always true/false" errors #25251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shoudn't it be "indicate" ? (without the "s") |
sheetalkamat
approved these changes
Jun 27, 2018
|
Thanks for indicating that typo. |
RyanCavanaugh
approved these changes
Jun 28, 2018
mihailik
reviewed
Jun 28, 2018
| @@ -1252,6 +1252,10 @@ | |||
| "category": "Error", | |||
| "code": 2366 | |||
| }, | |||
| "The types of these values indicate that this condition will always be '{0}'.": { | |||
There was a problem hiding this comment.
If those are statically known primitive types, can we include actual values in error message? Like:
"These values are known to be '{0}' and '{1}', rendering this condition always '{2}'."
There was a problem hiding this comment.
Check out #25311
| @@ -235,7 +238,8 @@ tests/cases/compiler/capturedLetConstInLoop5.ts(229,13): error TS2365: Operator | |||
| (() => x + y + v); | |||
| if (x == 1) { | |||
| ~~~~~~ | |||
| !!! error TS2365: Operator '==' cannot be applied to types '0' and '1'. | |||
| !!! error TS2367: The types of these values indicate that this condition will always be 'false'. | |||
There was a problem hiding this comment.
These values are known to be '0' and '1', rendering this condition always 'false'.
^^^^ how much smoother to comprehend and fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25245