Stop not emitting mappings for function and class names #25210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuckton
approved these changes
Jun 26, 2018
|
@andy-ms can you give this a quick test too. |
|
Tested in #24867 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @rbuckton
Ref #24867, #24866 and there was another issue about class names not having maps that I can't find that was probably caused by this, too. For some reason we were never emitting mappings for function and class names. We had explicitly disabled it. We can't seem to find any reasoning for why, so we should stop doing that, I guess, since it makes declaration maps (and probably normal sourcemaps) worse.