Handle combinations of rootdir and outdir when calculating paths

[weswigham]

By always calculating and using absolute paths when looking for symlinks.

Fixes this comment.

Followup to #24874.

[alan-agius4]

In which version will this be out? As with TypeScript 2.9 this is still any issue.

[mhegazy]

2.9.2. please file a new a ticket and give us more details to be able to diagnose.

[alan-agius4]

I have tried TS3 and the issue is fixed. Will either try to find which commit solved it, if I find some time in the coming days. If they is a chance for a patch, else I’ll wait for V3.

Thanks

[alan-agius4]

Nvm, just saw v3 has been released 😊

…

On Mon, 30 Jul 2018 at 18:27, Mohamed Hegazy ***@***.***> wrote: 2.9.2. please file a new a ticket and give us more details to be able to diagnose. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#24941 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQv-WtVQZMhdDCeRkhwTnbwClUHQV531ks5uLzP5gaJpZM4UnJTM> .

[raymondfeng]

@weswigham The original issue is mostly fixed. But we just ran into a variant of the problem now. See loopbackio/loopback-next#1643.

In this case, MetadataAccessor is exported from @loopback/metadata and re-exported by @loopback/context. Please note that @loopback/repository-json-schema module imports MetadataAccessor from @loopback/context. It leads to incorrectly generated code:

import { MetadataAccessor } from '@loopback/context';
import { JSONSchema6 as JSONSchema } from 'json-schema';
/**
 * Metadata key used to set or retrieve repository JSON Schema
 */
export declare const JSON_SCHEMA_KEY: MetadataAccessor<JSONSchema, import("../../context/node_modules/@loopback/metadata/src/types").DecoratorType>;

Switching the import to @loopback/metadata seems to fix the problem.

[raymondfeng]

@weswigham Any update? Should we open a new issue to track this?

[weswigham]

New issue would make it easier to track.

[raymondfeng]

@weswigham See #26985