Disallow assignments to imported exports #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7254,14 +7253,37 @@ module ts { | |||
| } | |||
| } | |||
|
|
|||
| function isImportedNameFromExternalModule(n: Node): boolean { | |||
There was a problem hiding this comment.
This is already an inner function so it should be able to refer to the node from the outer function. Why you have to pass it in as function argument?
There was a problem hiding this comment.
it is both the question of style (use explicit inputs\outputs for function) and potential optimization opportunities (in theory nested function that does not any captured data can be lifted to a higher scope)
|
👍 |
| stuff['x'] = 1; | ||
| stuff.blah = 2; | ||
| stuff[n] = 3; | ||
|
|
|
👍 |
vladima
added a commit
that referenced
this pull request
Mar 24, 2015
Disallow assignments to imported exports
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2456