Add support to TypeScript server for tsconfig.json files. #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 20, 2015 21:56
file F, the server will check whether F is configured by a tsconfig.json file. If so, the project specified by the tsconfig.json file becomes the LS context for F.
in directory configured by tsconfig.json, but file not part of the configured project.
| // TODO: pass true for file exiplicitly opened | ||
| var info = this.openFile(normRootFilename, false); | ||
| if (ts.sys.fileExists(rootFilename)) { | ||
| var info = this.openFile(rootFilename, clientFileName == rootFilename); |
| @@ -484,44 +508,77 @@ module ts.server { | |||
| this.printProjects(); | |||
| } | |||
|
|
|||
| gcConfiguredProjects() { | |||
There was a problem hiding this comment.
cleanConfiguredProjects or updateConfiguredProjects
|
Just a few comments. looks good to me, but i would rather have the findConfigFile logic shared with tsc.ts before it goes in. |
|
👍 |
steveluc
added a commit
that referenced
this pull request
Mar 24, 2015
Add support to TypeScript server for tsconfig.json files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a file F is opened by the host, the server will now check whether F is configured by a tsconfig.json file and, if so, use the specified project as the context for F.
Still TODO, monitor tsconfig.json files for changes and update configuration. For now, programmers will need to restart their editor to pick up the tsconfig.json file changes.