Expose setParentNodes on createCompilerHost #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
mhegazy
added a commit
that referenced
this pull request
Mar 18, 2015
Expose setParentNodes on createCompilerHost
| @@ -10,7 +10,7 @@ module ts { | |||
| /** The version of the TypeScript compiler release */ | |||
| export let version = "1.5.0.0"; | |||
|
|
|||
| export function createCompilerHost(options: CompilerOptions): CompilerHost { | |||
| export function createCompilerHost(options: CompilerOptions, setParentNodes?: boolean): CompilerHost { | |||
There was a problem hiding this comment.
Shouldn't this just be a compiler option then?
There was a problem hiding this comment.
I thought about that, but did not feel right, createSourceFile does not know about options. so it will be added, and only honored by the default cmd line host, which is a bit misleading.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are using createCompilerHost to create a program, there is no way to set the parent nodes. expose the value on the host creation function.