Fix emit destructuring in declaration file #2401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,10 @@ | |||
| // @declaration: true | |||
| var {a, b} = { a:10, b:"10"}; | |||
There was a problem hiding this comment.
can you add a test for something that does not use an exported type
module M {
class c {}
export var {a } : {a:C};
}
|
looks like this is already fixed in 649cd3b |
|
This PR #2025 has handled it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix following issue #2023.
Additional suggestion regarding emitting destructing in declaration file is allow destructuring in parameter position in ambient context so that language service can provide better signature help using information from .d.ts