Improve behaviour of ... inside JSDoc functions
#22809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Mar 22, 2018
| // from bcryptjs | ||
| /** @param {function(...[*])} callback */ | ||
| function g(callback) { | ||
| >g : (callback: (...arg0: [any][]) => any) => void |
There was a problem hiding this comment.
Was the intention to have a single-element tuple type in an array?
There was a problem hiding this comment.
Looks like it, given the implementation.
There was a problem hiding this comment.
Yes, this came from some real (but quite confused) jsdoc in bcryptjs. I think the author's intent was any[][] but they wrote ...[*]
src/compiler/checker.ts
Outdated
| @@ -24542,6 +24549,11 @@ namespace ts { | |||
| } | |||
| } | |||
| } | |||
| if (isParameter(parent) && isJSDocFunctionType(parent.parent)) { | |||
| if (last(parent.parent.parameters) === parent) { | |||
There was a problem hiding this comment.
Don't think this if is necessary, just use an array type all the time, we will issue a diagnostic for a non-last parameter anyway.
There was a problem hiding this comment.
Yeah, I guess you're right. I'm not sure adding | undefined as the fallback case ever makes sense, actually.
weswigham
approved these changes
Mar 22, 2018
ghost
approved these changes
Mar 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...typewhen it is the last parameter of a jsdocfunction()type....typeis marked as a rest parameter....typeresults intype[]inside a jsdoc function type.Fixes #22508