organizeImports: Fix bug in reference-testing for renamed import #22797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
amcasey
approved these changes
Mar 22, 2018
|
Will merge from #22799 once that's in to fix tests |
|
circleCI failure seems to be from testing against the older version? @FelicianoTech |
ghost
pushed a commit
that referenced
this pull request
Mar 22, 2018
ghost
mentioned this pull request
|
I'm actually not sure in this instance. |
mhegazy
added a commit
that referenced
this pull request
Mar 28, 2018
…renamed organizeImports: Fix bug in reference-testing for renamed import (#22797)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22743
In
import { a as b },aispropertyNamewhich won't have references besides itself.bisnamewhich is the symbol that will actually be used in the file.