Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable assertion for deferredUnusedIdentifierNodes #22604

Merged
1 commit merged into from
Mar 15, 2018
Merged

Disable assertion for deferredUnusedIdentifierNodes #22604

1 commit merged into from
Mar 15, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 15, 2018

Fixes #22578
Alternative to #22580 which is unlikely to make it in by 2.8.

@ghost ghost requested review from sandersn and weswigham March 15, 2018 17:03
@ghost ghost merged commit eb4dba7 into master Mar 15, 2018
@ghost ghost deleted the seenDeferred branch March 15, 2018 17:49
@mhegazy
Copy link
Contributor

mhegazy commented Mar 28, 2018

@andy-ms has this change been ported to release-2.8?

@ghost
Copy link
Author

ghost commented Mar 28, 2018 •
edited by ghost
Loading

Looks like seenDeferredUnusedIdentifiers (from #22516) isn't in release-2.8 anyway, so no need to port this.

@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhegazy @sandersn @weswigham