Enable the commented out test and convert folder entries to sorted list #22450
Conversation
|
@weswigham @mhegazy can you please run this locally to see if you run into errors, I was able to repro the test failure only couple of times before, but not once after this change. Can you please give it try before we can merge this in (since the original PR has passed successfully before i merged it) |
sheetalkamat
changed the title
| @@ -24,14 +24,14 @@ namespace ts { | |||
| * Make `elements` into a `NodeArray<T>`. If `elements` is `undefined`, returns an empty `NodeArray<T>`. | |||
| */ | |||
| export function createNodeArray<T extends Node>(elements?: ReadonlyArray<T>, hasTrailingComma?: boolean): NodeArray<T> { | |||
| if (elements) { | |||
| if (!elements || elements === emptyArray) { | |||
| elements = []; | |||
There was a problem hiding this comment.
This looks concerning. Does this happen often? Did you catch the code path where this occurres?
There was a problem hiding this comment.
I did look for exact code path since they are multiple ones but remember seeing this with code fix related node creations being one of them. it was discovered as part of #22167 when code fix related tests would cause those module resolution tests to fail....
|
Merging this after offline discussion with @mhegazy |
Trying out the tests since they dont fail on local machine