Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow trailing comman in type arguments list #22325

Closed
wants to merge 3 commits into from

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Mar 5, 2018

Fixes #21984

@Kingwl
Copy link
Contributor Author

Kingwl commented Mar 6, 2018

seems not my fault

@mhegazy
Copy link
Contributor

mhegazy commented May 23, 2018

@weswigham any objections to this change?

@bensaufley
Copy link

It seems like this, #21986, and #21984 are stagnating without comment/objection or merge/completion. What's the deal? If there's a reason not to allow this, and therefore not to merge this or #21986, and to close #21984, can it be posted somewhere?

@Kingwl Kingwl closed this Jul 9, 2018
@bensaufley
Copy link

Closed why?

@Kingwl
Copy link
Contributor Author

Kingwl commented Jul 10, 2018

@bensaufley my fault, i saw there are some related pr is existed...

@Kingwl Kingwl reopened this Jul 10, 2018
@RyanCavanaugh
Copy link
Member

I don't think we want to take this feature yet (issues marked Awaiting More Feedback generally shouldn't have PRs submitted). We're still trying to figure out what to do with partial type argument inference and this is just going to complicate the issue.

@Kingwl Kingwl deleted the imrpove-comma branch September 5, 2018 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants