Exports + .d.ts emit #2139
Merged
Exports + .d.ts emit #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rectly or indirectly
…ts emit Emit those new declarations asynchronously since they are otherwise not visible
Conflicts: tests/baselines/reference/es6ImportDefaultBinding.errors.txt tests/baselines/reference/es6ImportDefaultBindingFollowedWithNamedImport.errors.txt tests/baselines/reference/es6ImportDefaultBindingFollowedWithNamedImportInEs5.errors.txt tests/baselines/reference/es6ImportDefaultBindingFollowedWithNamespaceBinding.errors.txt tests/baselines/reference/es6ImportDefaultBindingFollowedWithNamespaceBindingInEs5.errors.txt tests/baselines/reference/es6ImportDefaultBindingInEs5.errors.txt
This was referenced Mar 6, 2015
|
Sorry to bother, do you know when this will be landing on master? It’s necessary for me to update dts-generator for use with ES6 modules. |
|
Hopefully by end of week. Sheetal has been sick for a while now, @vladima is picking it up. |
|
Great, thanks! I hope you feel better soon, @sheetalkamat ! Being sick is no fun. 😷 |
basarat
referenced
this pull request
in TypeStrong/atom-typescript
Mar 17, 2015
| @@ -1837,6 +1861,40 @@ module ts { | |||
| } | |||
| } | |||
|
|
|||
| function setDeclarationsOfIdentifierAsVisible(node: Identifier): Node[]{ | |||
There was a problem hiding this comment.
can we find a better name.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an aggregation of #2008 and #2025 and subsumes them.